Re: [PATCH] Modernize, improve and extend tests `pr*.test'.

[Ralf Wildenhues]

* Stefano Lattarini wrote on Wed, Jul 14, 2010 at 03:35:11PM CEST:
> Modernize, improve and extend tests `pr*.test'.
> 
> * tests/pr2.test: Add trailing `:' command.
> * tests/pr229.test: Likewise.
> * tests/pr401.test: Likewise.
> * tests/pr401b.test: Likewise.
> * tests/pr401c.test: Likewise.
> * tests/primary3.test: Likewise.
> * tests/pr211.test: Likewise.  Also, use the `configure.in' stub
> created by `./defs', rather than writing it from scratch.
> * tests/pr204.test: Likewise, plus cosmetic spacing changes.
> * tests/pr287.test: Likewise, and move setting of `errexit' shell
> flag earlier in the script (just after inclusion of ./defs).
> * tests/pr220.test: Make grepping of Automake's stderr stricter.
> Also, add trailing `:' command, and cosmetic changes in spacing.
> * tests/primary2.test: Likewise.
> * tests/primary.test: Likewise.
> * tests/pr224.test: Move setting of `errexit' shell flag earlier
> in the script (just after inclusion of ./defs).  Do not export
> `CC=gcc' to configure explicitly (it's already exported globally
> in ./defs, since we have "gcc" in $required).  Use the stub for
> `configure.in' created by `./defs', rather than writing it from
> scratch.  Do not create dummy files required by "gnu" mode (e.g.
> README, NEWS), since we run automake in foreign mode anyway.
> * tests/prefix.test: Enable `errexit' shell flags, and related
> changes.  Add a trailing `:' command.
> * tests/proginst.test: Likewise.
> * tests/pr87.test: Likewise.  Also, do not create dummy files
> required by "gnu" mode (e.g. README, NEWS), since we run automake
> in foreign mode anyway.
> * tests/pr72.test: Enable `errexit' shell flags, and related
> changes.  Extend existing checks a bit.
> * tests/pr9.test: Likewise.  Also, avoid obolescent constructs in
> the generated `configure.in', and extend existing checks over the
> generated tarball a bit.
> * tests/pr243.test: Avoid obolescent constructs in the generated
> `configure.in'.  Enable the `errexit' shell flag, and related
> changes.  Cosmetic changes to spacing, add trailing `:' command,
> and add a "FIXME" comment.
> * tests/pr266.test: Likewise.
> * tests/pr279.test: Avoid obolescent constructs in the generated
> `configure.in'; also, use the `configure.in' stub created by
> `./defs', rather than writing it from scratch.  Enable `errexit'
> shell flag, and related changes.  Add trailing `:' command.
> * tests/pr279-2.test: Likewise, and make grepping of Makefile.in
> stricter.
> * tests/pr300-prog.test: Cosmetic changes to spacing, and add a
> trailing `:' command.
> * tests/pr300-lib.test: Likewise.
> * tests/pr300-ltlib.test: Likewise, and ensure verbose printing
> of captured make stdout.
> * tests/pr307.test: Move setting of `errexit' shell flag earlier
> in the script (just after inclusion of ./defs).  Prefer fgrep
> over grep where possible, and escape literal dots in grep regular
> expressions.  Also, add a trailing `:' command, and cosmetic
> changes to spacing.

There is lots of noise in this patch.  I'm close to saying no to it
for that reason, but there is just enough improvement left that I'm ok
with it if you also add more meaningful descriptions to the tests, say,
the PR descriptions.  For example, after the patch, I have no idea what
pr9.test is about.  If you'd change the summary line to:

# Test for bug in PR 9: make dist incorrect when AC_CONFIG_AUX_DIR present

then it would make a bit more sense.

Thanks,
Ralf