automake-patches
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCHES] Bootstrap: Allow user overriding of $AUTOCONF and $PERL.


From: Stefano Lattarini
Subject: Re: [PATCHES] Bootstrap: Allow user overriding of $AUTOCONF and $PERL.
Date: Sun, 8 Aug 2010 12:09:52 +0200
User-agent: KMail/1.13.3 (Linux/2.6.30-2-686; KDE/4.4.4; i686; ; )

At Sunday 08 August 2010, Ralf Wildenhues wrote:
> [ the gnu list server seems down ATM; expect delays ]
> 
> Hi Stefano,
> 
> * Stefano Lattarini wrote on Wed, Jul 28, 2010 at 11:07:20AM CEST:
> > At Wednesday 28 July 2010, Ralf Wildenhues wrote:
> > > But even then, when developing Automake you will need to be
> > > extra careful to never let autoconf be invoked from the
> > > rebuild rules; because then, it will run plain "autoconf" and
> > > not the $AUTOCONF that you set.
> > 
> > Why? AUTOCONF is AC_SUBST by configure, so if I do:
> >   AUTOCONF=autoconf-2.67 ./boostrap
> >   AUTOCONF=autoconf-2.67 ./configure
> 
> (please pass variables as arguments to configure, so config.status
> --recheck remembers them.)
Right.  Will do.

> > there should be no problem.  Am I missing something?
> 
> You're right.  Only, that AUTOM4TE should be set, too, so that
> aclocal.tmp uses the right one.  Maybe it's prudent to set that
> here, too.
Yes, that would be a nice addition, if only for clarity.

I squashed the following into the first patch:

-*-*-

diff --git a/ChangeLog b/ChangeLog
index b6f801c..678b17e 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -2,7 +2,8 @@
 
        Bootstrap: let the user choose which autoconf to use.
        * bootstrap ($AUTOCONF): New variable, from the environment.
-       Use it instead of calling "autoconf" directly.
+       ($AUTOM4TE): Likewise, for clarity.
+       Use "$AUTOCONF" instead of calling "autoconf" directly.
 
 2010-08-06  Stefano Lattarini  <address@hidden>
 
diff --git a/bootstrap b/bootstrap
index 5577eeb..ebcedbe 100755
--- a/bootstrap
+++ b/bootstrap
@@ -35,8 +35,11 @@ set -e
 # Set program basename.
 me=`echo "$0" | sed 's,^.*/,,'`
 
-# Let user choose which version of autoconf to use.
+# Let user choose which version of autoconf and autom4te to use.
 : ${AUTOCONF=autoconf}
+export AUTOCONF  # might be used by aclocal and/or automake
+: ${AUTOM4TE=autom4te}
+export AUTOM4TE  # ditto
 
 # Find perl.  Code based on Autoconf, but without non-POSIX support.
 if test -z "$PERL"; then

-*-*-

It's OK for you?

> > (BTW, if my understanding is correct, this would make a nice
> > addition to HACKING, too).
> 
> Yep.
Attached is a follow-up patch that does that.  Comments and criticism
are welcome.

Thanks,
  Stefano

P.S. I'll fix the dates in the ChangeLog entried before pushing.
From 44201dba0cb5d6f7bb75158197e16e2a8333cdde Mon Sep 17 00:00:00 2001
From: Stefano Lattarini <address@hidden>
Date: Sun, 8 Aug 2010 12:05:45 +0200
Subject: [PATCH] Bootstrap: updated HACKING entry.

* HACKING ("Working with git"): Tell how to override the autoconf
and autom4te used by the bootstrap process.
---
 ChangeLog |    6 ++++++
 HACKING   |    7 ++++++-
 2 files changed, 12 insertions(+), 1 deletions(-)

diff --git a/ChangeLog b/ChangeLog
index 048c537..87e7bdd 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,5 +1,11 @@
 2010-07-27  Stefano Lattarini  <address@hidden>
 
+       Bootstrap: updated HACKING entry.
+       * HACKING ("Working with git"): Tell how to override the autoconf
+       and autom4te used by the bootstrap process.
+
+2010-07-27  Stefano Lattarini  <address@hidden>
+
        Bootstrap: fixlet.
        * bootstrap: Do not remove `lib/Automake/Config.pm' anymore,
        since we don't generate it.  Correctly quote arguments of
diff --git a/HACKING b/HACKING
index 2e404f5..ca2aefe 100644
--- a/HACKING
+++ b/HACKING
@@ -96,7 +96,12 @@
   tree, so the resulting files (aclocal.m4 and Makefile.in) should
   be the same as you would get if you install this version of
   automake and use it to generate those files.  Be sure to have the
-  latest stable version of Autoconf installed.
+  latest stable version of Autoconf installed.  If such version is
+  not installed as the default "autoconf" command, you'll have to
+  pass it explicitly (along with the accompanying "autom4te") when
+  calling `bootstrap' and `configure'.  For example:
+    $ AUTOCONF=autoconf2.65 AUTOM4TE=autom4te2.65 ./boostrap
+    $ ./configure AUTOCONF=autoconf2.65 AUTOM4TE=autom4te2.65
 
 * Dependent files aclocal.m4, configure and Makefile.in in all
   directories should be up to date in the git repository, so that
-- 
1.7.1


reply via email to

[Prev in Thread] Current Thread [Next in Thread]