[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] Internationalization tests: prefer `make distdir' over `make
|
From: |
Ralf Wildenhues |
|
Subject: |
Re: [PATCH] Internationalization tests: prefer `make distdir' over `make dist'. |
|
Date: |
Mon, 6 Sep 2010 20:31:28 +0200 |
|
User-agent: |
Mutt/1.5.20 (2010-04-22) |
* Stefano Lattarini wrote on Mon, Sep 06, 2010 at 04:56:50PM CEST:
> Internationalization tests: prefer `make distdir' over `make dist'.
>
> Instead of running `make dist', then uncompressing the created
> tarball, and then grepping the uncompressed tar archive, we can
> simply run `make distdit' and anylize. This is both faster and
distdir
> cleaner.
>
> * tests/pot-msgidbugs.test: Test updated to use `make distdir'
> instead of `make dist' where possible.
> * tests/pot-no-linguas.test: Likewise.
> * tests/pot-override1.test: Likewise.
> * tests/pot-xgettext1.test: Likewise.
> * tests/pot-xgettext2.test: Likewise.
> * tests/pot-xgettext3.test: Likewise.
> * tests/pot-xgettext4.test: Likewise.
> * tests/pot-download1.test: Likewise, and check the created
> distdir instead of the distribution tarball (which is not even
> created anymore).
> ($distdir): New variable.
> * tests/pot-format-csharp1.test: Likewise.
> * tests/pot-format-java1.test: Likewise.
> * tests/pot-format-java2.test: Likewise.
> * tests/pot-format-qt1.test: Likewise.
> * tests/pot-format-tcl1.test: Likewise.
> * tests/pot-linguas.test: Likewise.
> * tests/pot-noinst.test: Likewise.
> * tests/pot-samedir.test: Likewise.
> * tests/pot-topsrcdir.test: Likewise.
This looks fine to me, barring objections from Bruno.
Thanks,
Ralf
[PATCH] Internationalization tests: prefer `test ! -r' over `test ! -f', Stefano Lattarini, 2010/09/06