[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 1/4] {branch "tests-init"} Tests defs: $srcdir is uncondition
From: |
Ralf Wildenhues |
Subject: |
Re: [PATCH 1/4] {branch "tests-init"} Tests defs: $srcdir is unconditionally substituted. |
Date: |
Mon, 6 Sep 2010 21:13:54 +0200 |
User-agent: |
Mutt/1.5.20 (2010-04-22) |
* Stefano Lattarini wrote on Mon, Sep 06, 2010 at 08:59:20PM CEST:
> On Monday 06 September 2010, Ralf Wildenhues wrote:
> > > "Unfortunately", there is no bug fixed by this patch. I can only
> > > offer the above argumentation (plus consistency of $testsrcdir
> > > and $top_testsrcdir).
> >
> > Your verbose explanation above and this seem to contradict each
> > other. ;-)
> I'll probably look like an idiot unable to understand basic humourism,
> but I have to ask... Why?
Well, you explained that with the old code,
address@hidden@}
it was still necessary that afterwards, $srcdir would be equal to the
absolute source directory name, which means, a user setting of $srcdir
could cause a bug, like this:
srcdir=elsewhere ./foo.test
> The old code wasn't bugged, it was just
> uselessly redundant (which, mind it, is IMHO a good enough reason to
> accept the patch). Does this makes sens?
No. The old code *was* buggy, and that's why your patch is ok.
;-)
Thanks,
Ralf
- [PATCH 0/4] {branch "tests-init"} Tests defs: renamings, tweakings and extensions in some global variables, Stefano Lattarini, 2010/09/02
- [PATCH 1/4] {branch "tests-init"} Tests defs: $srcdir is unconditionally substituted., Stefano Lattarini, 2010/09/02
- Re: [PATCH 1/4] {branch "tests-init"} Tests defs: $srcdir is unconditionally substituted., Ralf Wildenhues, 2010/09/05
- Re: [PATCH 1/4] {branch "tests-init"} Tests defs: $srcdir is unconditionally substituted., Stefano Lattarini, 2010/09/05
- Re: [PATCH 1/4] {branch "tests-init"} Tests defs: $srcdir is unconditionally substituted., Ralf Wildenhues, 2010/09/06
- Re: [PATCH 1/4] {branch "tests-init"} Tests defs: $srcdir is unconditionally substituted., Stefano Lattarini, 2010/09/06
- Re: [PATCH 1/4] {branch "tests-init"} Tests defs: $srcdir is unconditionally substituted., Ralf Wildenhues, 2010/09/06
- Re: [PATCH 1/4] {branch "tests-init"} Tests defs: $srcdir is unconditionally substituted., Stefano Lattarini, 2010/09/06
- Re: [PATCH 1/4] {branch "tests-init"} Tests defs: $srcdir is unconditionally substituted.,
Ralf Wildenhues <=
Re: [PATCH 2/4] {branch "tests-init"} Tests defs: new variable $top_srcdir., Stefano Lattarini, 2010/09/02
[PATCH 3/4] {branch "tests-init"} Tests defs: remove variable $testaclocaldir., Stefano Lattarini, 2010/09/02
[PATCH 4/4] {branch "tests-init"} Tests defs: $srcdir and $top_srcdir renaming., Stefano Lattarini, 2010/09/02
[PUSH] {branch "tests-init"} Tests defs: renamings, tweakings and extensions in some global variables, Stefano Lattarini, 2010/09/06