[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] dist-xz: don't hard-code -9: honor setting of XZ_OPT

From: Lasse Collin
Subject: Re: [PATCH] dist-xz: don't hard-code -9: honor setting of XZ_OPT
Date: Mon, 11 Oct 2010 23:17:57 +0300
User-agent: KMail/1.13.5 (Linux/2.6.35-ARCH; KDE/4.5.1; x86_64; ; )

On 2010-10-11 Ralf Wildenhues wrote:
> with Jim's patch in place, and XZ_OPT *not* set in the environment,
> I get the following Automake test failure with
> $ xz --version
> xz (XZ Utils) 4.999.8beta
> liblzma 4.999.8beta
> (yes, that's not the newest version; no, we shouldn't support just
> the newest version).

4.999.8beta shouldn't be used for anything, because it has a data 
corruption bug. It might be patched in some distros that didn't want to 
upgrade the whole package, so the version number doesn't tell 

> So, time to rethink this feature?  Maybe we need to check first
> whether XZ_OPT is parsed correctly by xz at all?

I think that 4.999.8beta is not worth supporting, but just in case you 
still do: People can use XZ_OPT even if it is not put there by Automake. 
Then the default level will be -6. If you want -9 to be the default, 
maybe this is OK:

    xz_preset= ; if test -z "$XZ_OPT"; then xz_preset=-9; fi; \
    tardir=$(distdir) && $(am__tar) | xz $$xz_preset >$(distdir).tar.xz

Lasse Collin  |  IRC: Larhzu @ IRCnet & Freenode

reply via email to

[Prev in Thread] Current Thread [Next in Thread]