[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 1/7] Tests defs: various reorderings, some improvements.
From: |
Ralf Wildenhues |
Subject: |
Re: [PATCH 1/7] Tests defs: various reorderings, some improvements. |
Date: |
Thu, 11 Nov 2010 06:59:20 +0100 |
User-agent: |
Mutt/1.5.20 (2010-08-04) |
* Stefano Lattarini wrote on Thu, Nov 11, 2010 at 12:37:23AM CET:
> Well, the patch is "almost" just code reordering, with the very minor
> exceptions that:
>
> 1. in the older version, some error messages could be printed before
> `$me' was defined, so they couldn't use it; now `$me' is defined
> early, so those error messages has been amended to include it;
>
> 2. in the older version, a test might be skipped from within code
> in `tests/defs' *after* the exit trap was installed, so a call
> to "Exit 77" was in order; now the skips only happens before the
> installation of the exit trap, so "exit 77" is enough;
>
> 3. some comments has been slighty adjusted and extended, because the
> act of reordering the code suggested them to me.
>
> Anyway, none of these additional "minor" changes is really required to
> make the new `tests/defs.in' work correctly, so I agree that they should
> have been done in follow-up patches. I've respin and split my patch to
> do so (see the attached four patches).
Thank for respinning. The patches are ok then, but I think you should
take care that the newly-introduced `pwd` is replaced by the variable
you later introduce for this (in the later patch, of course).
Thanks,
Ralf
- [PATCH 0/7] Refactoring of testcases initialization code (was: Re: [PATCH 0/5] More cosmetic and consistency changes for tests/defs), Stefano Lattarini, 2010/11/07
- [PATCH 1/7] Tests defs: various reorderings, some improvements., Stefano Lattarini, 2010/11/07
- Re: [PATCH 1/7] Tests defs: various reorderings, some improvements., Ralf Wildenhues, 2010/11/10
- Re: [PATCH 1/7] Tests defs: various reorderings, some improvements., Stefano Lattarini, 2010/11/10
- Re: [PATCH 1/7] Tests defs: various reorderings, some improvements.,
Ralf Wildenhues <=
- Re: [PATCH 1/7] Tests defs: various reorderings, some improvements., Stefano Lattarini, 2010/11/11
- Re: [PATCH 1/7] Tests defs: various reorderings, some improvements., Ralf Wildenhues, 2010/11/11
[PATCH 2/7] Tests defs: prefer "$curdir" over "`pwd`"., Stefano Lattarini, 2010/11/07
[PATCH 3/7] Tests defs: rename $curdir -> $testbuilddir, Stefano Lattarini, 2010/11/07
[PATCH 4/7] Tests defs: do not print message "Running test $0" anymore., Stefano Lattarini, 2010/11/07
[PATCH 5/7] Tests defs: $testsbuilddir is now AC_SUBST'ed., Stefano Lattarini, 2010/11/07