[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 1/3] aclocal: handle ACLOCAL_PATH environment variable

From: Ralf Wildenhues
Subject: Re: [PATCH 1/3] aclocal: handle ACLOCAL_PATH environment variable
Date: Sat, 13 Nov 2010 12:47:40 +0100
User-agent: Mutt/1.5.20 (2010-08-04)

* Paolo Bonzini wrote on Tue, Nov 09, 2010 at 08:14:38PM CET:
> This updated patch passes the tests suggested by Stefano.  Considering
> that Automake will rarely if ever be invoked from outside, MSYS, I stuck
> with the colon as the sole separator for ACLOCAL_PATH.
> The test suites leaves the user's ACLOCAL_PATH in place, for consistency
> with the treatment of ${prefix}/share/aclocal/dirlist in tests/,
> but overrides it in the two dedicated tests.
> I needed to tweak the tests/ script to avoid passing the
> srcdir to -I (which happens if building in srcdir).  Otherwise, the
> assumptions of the precedence tests in acloca25.test are not respected.
> * NEWS: Document new behavior.
> * (parse_arguments): Parse ACLOCAL_PATH as a colon-separated
> list of directories to be included in the search path.
> * doc/automake.texi (Macro Search Path): Document new behavior and
> the precedence rules for various elements of the search path.
> * tests/ (TESTS): Add new testcases.
> * tests/acloca24.test: New testcase.
> * tests/acloca25.test: New testcase.
> * tests/ Special-case in-srcdir build, so that -I is not used
> if it brings in unwanted m4 files.

This patch is OK.  I've committed it locally to a new branch based off
maint (but the change is intended for master only of course), and can
push it for you when we've dealt with the other ones.  (Ping me if you'd
like write access to automake.git, AFAICS you don't have that ATM.)


reply via email to

[Prev in Thread] Current Thread [Next in Thread]