automake-patches
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCHES] Fix spurious failures of some tests `silent*.test' with Su


From: Ralf Wildenhues
Subject: Re: [PATCHES] Fix spurious failures of some tests `silent*.test' with SunStudio Fortran
Date: Wed, 17 Nov 2010 19:02:13 +0100
User-agent: Mutt/1.5.20 (2010-08-04)

Hi Stefano,

* Stefano Lattarini wrote on Wed, Nov 17, 2010 at 03:25:02PM CET:
> I'm seeing this failure with SunStudio fortran compilers on
> Debian GNU/Linux (and a similar failure on Solaris 10):

>  make[1]: Entering directory 
> `/home/stefano/src/automake/tests/silentf77.dir/sub'
>    F77    bar.o
>  NOTICE: Invoking /opt/SunStudio/sunstudio12.1/prod/bin/f90 -f77 -ftrap=%none 
> -g -c -o bar.o bar.f

> The test `silent5.test' experiences a similar failure.
> 
> Now, these failure are clearly spurious, and easy worked around,
> so I'd like to apply the attached patches to temporary bugfixing
> branches, and merge them to maint.

Well, the question that comes to mind is, is there a flag with which we
could silence the compiler?  The user might just not want to read that
NOTICE.

If not, then I'd squash the two patches together (is there a point in
keeping them separate?), and relax the sed pattern to kill all lines
matching '^NOTICE:'.  Even that might eventually not be enough with
localization, but at least then you aren't relying on specific compiler
flags that might not be valid with a different compiler version, or
different flags in $FCFLAGS or $FFLAGS.

Thanks,
Ralf

> Subject: [PATCH] Fix spurious failures of silent-rules tests with Sun Fortran.
> 
> * tests/silentf77.test: Strip from the make output some verbose
> messages possibly printed by the SunStudio fortran compilers, to
> avoid spurious failures.  Add a trailing `:' command.
> * tests/silentf90.test: Likewise.

> +# Avoid spurious failures with SunStudio Fortran compilers.
> +sed '/^NOTICE: *[Ii]nvoking.*-ftrap=%none/d' stdout > t
> +mv -f t stdout
> +cat stdout

> Subject: [PATCH] Fix spurious failures of silent5.test with Sun Fortran.
> 
> * tests/silent5.test: Strip from the make output some verbose
> messages possibly printed by the SunStudio fortran compilers,
> to avoid spurious failures.  This bug has been there from the
> very first version of this test script.



reply via email to

[Prev in Thread] Current Thread [Next in Thread]