[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 11/10] Update NEWS about the warnings-over-strictness precede

From: Ralf Wildenhues
Subject: Re: [PATCH 11/10] Update NEWS about the warnings-over-strictness precedence.
Date: Sun, 2 Jan 2011 16:37:59 +0100
User-agent: Mutt/1.5.20 (2010-08-04)

* Stefano Lattarini wrote on Fri, Dec 24, 2010 at 07:02:53PM CET:
> Update NEWS about the warnings-over-strictness precedence.
> * NEWS: Automake explicit warning levels always take precedence
> over the implicit warning levels implied by Automake strictness.

> --- a/NEWS
> +++ b/NEWS
> @@ -91,6 +91,16 @@ Bugs fixed in 1.11a:
>    - Rules generated by Automake now try harder to not change any files when
>      `make -n' is invoked.  Fixes include compilation of Emacs Lisp, Vala, or
>      Yacc source files and the rule to update config.h.
> +
> +  - Now explicit enabling and/or disabling of Automake warning categories
> +    through the `-W...' options always takes precedence over the implicit

I'd move the "now" to right before "always".

> +    warning level implied by an Automake strictness (foreign, gnu, gnits),

s/an //
s/gnits/or &/

> +    regardless of the order in which such strictness and warning flags
> +    appears.  For example, a setting like:


> +      AUTOMAKE_OPTIONS = -Wall --foreign
> +    will cause the warnings in category `portability' to be enabled, even
> +    if those warnings are by default disabled in `foreign' strictness.

OK with that addressed.

Thanks, and sorry for the slight out-of-order review, I like to get the
easy ones out of the way quickly,

reply via email to

[Prev in Thread] Current Thread [Next in Thread]