Re: [PATCH 08/10] Add more tests about AUTOMAKE_OPTIONS.

[Stefano Lattarini]

On Sunday 02 January 2011, Ralf Wildenhues wrote:
> * Stefano Lattarini wrote on Sun, Jan 02, 2011 at 06:45:07PM CET:
> > On Sunday 02 January 2011, Ralf Wildenhues wrote:
> > > * address@hidden wrote on Thu, Dec 23, 2010 at 12:27:44PM CET:
> 
> > > > +cat > Makefile.am <<'END'
> > > > +AUTOMAKE_OPTIONS = $(foo) foreign
> > > > +AUTOMAKE_OPTIONS += ${bar}
> > > > +foo = $(foo1)
> > > > +foo1 = ${foo2}
> > > > +foo2 = -Wnone
> > > > +foo2 += $(foo3)
> > > > +foo3 = -Wno-error
> > > > +bar = -Wportability
> > > 
> > > This seems a wee bit convoluted (i.e., hard to parse by human upon first
> > > reading), but oh well, that's more of a testsuite QoI nit.
> > >
> > Do you have any clarifying comment to suggest?  I'd be happy to add it.
> 
> How about this?
>  # The following should expand to `-Wnone -Wno-error foreign -Wportability'.
> 
Yes, I like it.  Comment added.

> Hey, we could even grep for that in the verbose output somewhere ...
> 
> > > > +$ACLOCAL
> > > > +AUTOMAKE_fails
> > > 
> > > What are the expected failures here?
> > >
> > Aren't the next greps explicit enough?  If not, would this comment help
> > in clarifying the situation?
> > 
> >  # Automake options 'tar-v7', 'tar-ustar' and 'tar-pax' can only be used
> >  # as argument to AM_INIT_AUTOMAKE, and not in AUTOMAKE_OPTIONS.
> 
> The comment definitely helps, and should be enough IMHO.  Thank you.
>
Good.

> [CUT]
> 
> > > Just to be sure, this patch does not rely upon any of the previous ones,
> > > right?
> > >
> > Hmm... I didn't pay attention to this fact before, but yes, I believe
> > the patch should not depend on earlier ones.
> > 
> > Anyway, I bacame aware the necessity of the new tests only when I got to
> > modify the automake code dealing with AUTOMAKE_OPTIONS; and that's why
> > I didn't add them in an earlier patch.
> 
> Well, if you like, you can just push this patch to master independently;
> or leave it here if you prefer.
>
I'd rather wait than having to juggle even more with "git am" and
"git rebase", if that's ok with you (silence gets interpreted as
a positive answer here ;-).

> [BIG CUT]
>
> All better, no objections!
> 
> Thanks!
> Ralf
> 

Regards,
  Stefano