automake-patches
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: local perl $_ variable is not portable


From: Ralf Wildenhues
Subject: Re: local perl $_ variable is not portable
Date: Mon, 17 Jan 2011 07:46:31 +0100
User-agent: Mutt/1.5.20 (2010-08-04)

* Stefano Lattarini wrote on Mon, Jan 17, 2011 at 01:39:29AM CET:
> On Sunday 16 January 2011, Ralf Wildenhues wrote:
> >    foreach my $h (@list)
> >      {
> > -      my $_ = $h->{'option'};

> > +      $_ = $h->{'option'};
> >
> What about using a "good ol' local" here?  E.g.:
>   local $_ = $h->{'option'};
> That should be portable to any perl 5.x, and a bit safer.

OK, good enough.

> BTW, I'd also add to the ChangeLog entry the "git describe" output
> for the commit where I messed things up (if I'm not mistaken, it
> should be `v1.11-622-gf90a06c').

Done, and committed right on top of that commit.

Thanks for the quick review,
Ralf



reply via email to

[Prev in Thread] Current Thread [Next in Thread]