[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] {maint} tests: tempdirs with restrictive permissions are cle
|
From: |
Eric Blake |
|
Subject: |
Re: [PATCH] {maint} tests: tempdirs with restrictive permissions are cleaned correctly |
|
Date: |
Mon, 21 Feb 2011 07:14:01 -0700 |
|
User-agent: |
Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.2.13) Gecko/20101209 Fedora/3.1.7-0.35.b3pre.fc14 Lightning/1.0b3pre Mnenhy/0.8.3 Thunderbird/3.1.7 |
On 02/20/2011 04:39 AM, Stefano Lattarini wrote:
>>> - find "$$@" -type d '!' -perm -200 -exec chmod u+w {} ';'; \
>>> + find "$$@" -type d ! -perm -700 -exec chmod u+rwx {} ';'; \
>>> rm -rf "$$@"; \
>>> fi;
>>
>> please don't remove the quoting from the ! here. It exists to
>> facilitate copy and pasting commands from make output to the command
>> line,
>>
> Why would the quoting being useful for that? As long as '!' is
> whitespace-separated from the following word, it's regarded by
> the shell as a literal character, even when the shell has history
> substutution enabled, no? Or am I missing something?
You're missing history expansion. ! is special in some interactive
shells when not in POSIX mode. It's better to quote ! than to risk a
spurious history expansion.
--
Eric Blake address@hidden +1-801-349-2682
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature