automake-patches
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: subdir-objects, dirstamps and --disable-dependency-tracking (bug!)


From: Ralf Wildenhues
Subject: Re: subdir-objects, dirstamps and --disable-dependency-tracking (bug!)
Date: Sat, 2 Apr 2011 11:14:11 +0200
User-agent: Mutt/1.5.20 (2010-08-04)

* Stefano Lattarini wrote on Fri, Apr 01, 2011 at 04:54:59PM CEST:
> On Friday 01 April 2011, Ralf Wildenhues wrote:
> >     Create subdirs for generated sources even when not dep tracking.
> >     
> >     * automake.in (handle_single_transform): If $object is derived
> >     and lands in subdir, be sure to output a dirstamp dependency.
> >     * tests/lex-subobj-nodep.test: New test.
> >     * tests/Makefile.am (TESTS): Update.
> >     * THANKS: Update.
> >
> Shouldn't NEWS be updated too?  Or is the bugfix too small to warrant
> that?

Seems fairly minor (and rarely encountered) to me.

> > +int
> > +main ()
> >
> Isn't the linebreak after "int" an overkill here?
> Also, if you really want to follow the GNU standards even in testcase
> data, shouldn't "main" have a full prototype like "int main (void)"?
> (in that case, you might want to fix the "yywrap" prototype below too).
> 
> > +{
> > +  while (yylex () != EOF)
> > +    ;
> > +
> Why this extra blank line?  I really have no problem with it, but since
> you seem to prefer not to waste vertical space uselessly, I decided to
> point out this minor inconsistency.  Feel free to ignore it, though.

I compactified that a bit now, thanks.  Previously, I had just copied
from some other tests.

Turned out that yacc5.test started failing due to this change, so I've
fixed that as below in the patch as well, and pushed to maint.

Thanks,
Ralf

--- a/tests/yacc5.test
+++ b/tests/yacc5.test
@@ -1,5 +1,5 @@
 #! /bin/sh
-# Copyright (C) 2001, 2002, 2003  Free Software Foundation, Inc.
+# Copyright (C) 2001, 2002, 2003, 2011 Free Software Foundation, Inc.
 #
 # This program is free software; you can redistribute it and/or modify
 # it under the terms of the GNU General Public License as published by
@@ -42,7 +42,7 @@ mkdir sub
 $ACLOCAL
 $AUTOMAKE -a
 
-grep '^maude\.c:' Makefile.in
+grep '^maude\.c:.*maude\.y' Makefile.in
 
 
 ## Try again with subdir-objects.
@@ -56,8 +56,9 @@ END
 $ACLOCAL
 $AUTOMAKE -a
 
-# No rule needed, the default .y.c: inference rule is enough.
-grep '^sub/maude\.c:' Makefile.in && Exit 1
+# No rule needed, the default .y.c: inference rule is enough
+# (but there may be an additional dependency on a dirstamp file).
+grep '^sub/maude\.c:.*maude\.y' Makefile.in && Exit 1
 
 
 ## Try again with per-exe flags.
@@ -80,3 +81,5 @@ grep 'maudec' Makefile.in && Exit 1
 
 # Make sure the .o file is required.
 grep '^am_maude_OBJECTS.*maude' Makefile.in
+
+:



reply via email to

[Prev in Thread] Current Thread [Next in Thread]