automake-patches
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [FYI] {maint,master} test defs: allow overriding of `$me'


From: Ralf Wildenhues
Subject: Re: [FYI] {maint,master} test defs: allow overriding of `$me'
Date: Sun, 17 Apr 2011 21:32:21 +0200
User-agent: Mutt/1.5.20 (2010-08-04)

* Stefano Lattarini wrote on Sun, Apr 17, 2011 at 09:08:54PM CEST:
> On Sunday 17 April 2011, Ralf Wildenhues wrote:
> > Otherwise you will have spurious failures (and to some extent
> > "arbitrary code execution" upon a testsuite run).
> >
> What about initilizing me from `$am_test_name' then?  On the line of:

That's a little better, but not much.  In principle, all environment we
depend on should have a good reason we do.  We get sporadic bug reports
in autotools about all kinds of variables that we inherit and use, e.g.,
$U.  All such variables need to be documented, and, as much as possible,
sanitized.  I simply don't understand why you need $me adjustable, and
the name does not imply that Automake's uses it, or what it would use it
for.  am_test_name is better, but doesn't explain either why it would be
needed in the first place.

Thanks,
Ralf



reply via email to

[Prev in Thread] Current Thread [Next in Thread]