automake-patches
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[FYI] {yacc-work} lex tests: remove erroneous check about ylwrap distrib


From: Stefano Lattarini
Subject: [FYI] {yacc-work} lex tests: remove erroneous check about ylwrap distribution
Date: Fri, 13 May 2011 15:07:32 +0200
User-agent: KMail/1.13.3 (Linux/2.6.30-2-686; KDE/4.4.4; i686; ; )

* tests/lex5.test: Do not check that the ylwrap script is *not*
distributed when there is only one lexer, as ylwrap is in fact
expected to distributed unconditionally (at least starting from
commit `Release-1-9-323-gc5881cc' of 19-08-2006).  Note that this
bogus check wasn't triggering any failure because it was done at
the wrong time (i.e. from the VPATH build directory), so that it
could never fail anyway.
Instead, check that ylwrap is distributed even when there is only
one lexer.
Since we are at it, add a couple of `ls -l' calls, to get better
debugging info.
---
 ChangeLog       |   17 ++++++++++++++++-
 tests/lex5.test |    9 ++++++---
 2 files changed, 22 insertions(+), 4 deletions(-)

diff --git a/ChangeLog b/ChangeLog
index 91f8696..1144ba9 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,6 +1,21 @@
 2011-05-12  Stefano Lattarini  <address@hidden>
 
-       tests: "make clean" removes C++ files from non-distributed .y
+       lex tests: remove erroneous check about ylwrap distribution
+       * tests/lex5.test: Do not check that the ylwrap script is *not*
+       distributed when there is only one lexer, as ylwrap is in fact
+       expected to distributed unconditionally (at least starting from
+       commit `Release-1-9-323-gc5881cc' of 19-08-2006).  Note that this
+       bogus check wasn't triggering any failure because it was done at
+       the wrong time (i.e. from the VPATH build directory), so that it
+       could never fail anyway.
+       Instead, check that ylwrap is distributed even when there is only
+       one lexer.
+       Since we are at it, add a couple of `ls -l' calls, to get better
+       debugging info.
+       
+2011-05-12  Stefano Lattarini  <address@hidden>
+
+       yacc tests: "make clean" removes C++ files from non-distributed .y
        * tests/yacc-clean-cxx.test: New test, sister of `yacc-clean.test'.
        * tests/yacc-clean.test: Update heading comment to reference the
        new sister test.
diff --git a/tests/lex5.test b/tests/lex5.test
index 12d9f00..fd394eb 100755
--- a/tests/lex5.test
+++ b/tests/lex5.test
@@ -58,15 +58,18 @@ $ACLOCAL
 $AUTOCONF
 $AUTOMAKE -a
 
+# We expect ylwrap to be used and distributed even if there is
+# only one lexer.
+test -f ylwrap
+
 mkdir sub
 cd sub
 ../configure
 $MAKE foo/foo.o
+ls -l # For debugging.
 
 test -f foo/foo.c
 test -f foo/foo.o
-# ylwrap is not needed
-test ! -f ./ylwrap
 
 # Now, adds another lexer to test ylwrap.
 
@@ -84,11 +87,11 @@ END
 $sleep
 
 $AUTOMAKE -a --no-force
-test -f ./ylwrap
 
 cd sub
 using_gnumake || $MAKE Makefile
 $MAKE foo/foo2.o
+ls -l # For debugging.
 test -f foo/foo2.c
 test -f foo/foo2.o
 
-- 
1.7.2.3



reply via email to

[Prev in Thread] Current Thread [Next in Thread]