automake-patches
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Automake patches for custom test drivers' support break coreutils te


From: Jim Meyering
Subject: Re: Automake patches for custom test drivers' support break coreutils testsuite
Date: Sat, 18 Jun 2011 13:28:05 +0200

Stefano Lattarini wrote:
>> ...
>> >
>> > In order to work with the upcoming new Automake testsuite harness, 
>> > coreutils
>> > have two possibilities:
>> >  1. move the `shell_or_perl_' subroutine's functionality into a real 
>> > acript,
>> >     and define the LOG_COMPILER to point to it; or
>> >  2. add a `.pl' extension to the perl test scripts, and define 
>> > PL_LOG_COMPILER
>> >     appropriately (might be a little tricky, considering the hops that the
>> >     `shell_or_perl_' subroutine goes through in order to get the flags and
>> >     imports right).
>>
>> 1) sounds preferable.
>>
> But it has a serious drawback: the redirection `9>&2' placed at the end
> of TESTS_ENVIRONMENT will be rendered useless by the final exec done
> in the new `shell_or_perl' script (at least for with shells using the
> `cloexec' flag on fds > 2); this will bring back the problems fixed by
> commit `v8.12-82-g6b68745' :-(
>
> So I now think we should go with solution (2).

Ok.



reply via email to

[Prev in Thread] Current Thread [Next in Thread]