[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 1/2] tests: make test runner a script, not a shell function

From: Ralf Wildenhues
Subject: Re: [PATCH 1/2] tests: make test runner a script, not a shell function
Date: Mon, 20 Jun 2011 22:22:30 +0200

* Stefano Lattarini wrote on Mon, Jun 20, 2011 at 10:22:28AM CEST:
> [Adding bug-grep, dropping bug-coreutils and automake-patches]

re-adding the latter.

> I've noticed that grep uses a definition of TESTS_ENVIRONMENT very similar
> to that of coreutils (the one we've just fixed), so it will break with
> oncoming automake too.

That may be a sign that you may not want to actually break this code
with your proposed changes to Automake.

Put another way: it's a good idea to estimate the level of breakage
you're going to burden upon others (a couple of projects, dozens,
hundreds), the amount of work needed on their side to fix it, and the
amount of work (or possibility) it would take to change your code so
they are not broken in the first place.

Also, of course, NEWS entries (and probably automake.texi entries) for
such changes are a good idea.

One thing I've regularly done with new code that is not 100% backward
compatible is have a new Automake option for them.  That is exactly why
there is a 'parallel-tests': it is not fully compatible with the simple
test driver, and requires work on behalf of developers using Automake.

> Unfortunately, I don't have an FSF assignment
> for grep, so someone else should fix that issue :-(

You can do minor fixes without assignments.
(Of course, I don't maintain grep, so it's up to them.)


reply via email to

[Prev in Thread] Current Thread [Next in Thread]