automake-patches
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[FYI] {testsuite-work} tests: fix an incomplete comment


From: Stefano Lattarini
Subject: [FYI] {testsuite-work} tests: fix an incomplete comment
Date: Fri, 24 Jun 2011 09:52:02 +0200
User-agent: KMail/1.13.3 (Linux/2.6.30-2-686; KDE/4.4.4; i686; ; )

* tests/subst-no-trailing-empty-line.test: Fix an incomplete
comment, and move it to a more proper place.  Minor cosmetic
fixes to other comments.
---
 ChangeLog                               |    7 +++++++
 tests/subst-no-trailing-empty-line.test |   14 +++++++++-----
 2 files changed, 16 insertions(+), 5 deletions(-)

diff --git a/ChangeLog b/ChangeLog
index 83bae8d..37f029c 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,10 @@
+2011-06-24  Stefano Lattarini  <address@hidden>
+
+       tests: fix an incomplete comment
+       * tests/subst-no-trailing-empty-line.test: Fix an incomplete
+       comment, and move it to a more proper place.  Minor cosmetic
+       fixes to other comments.
+
 2011-06-20  Stefano Lattarini  <address@hidden>
 
        maintcheck: avoid few more spurious failures
diff --git a/tests/subst-no-trailing-empty-line.test 
b/tests/subst-no-trailing-empty-line.test
index 595644e..a970174 100755
--- a/tests/subst-no-trailing-empty-line.test
+++ b/tests/subst-no-trailing-empty-line.test
@@ -23,16 +23,19 @@
 
 . ./defs || Exit 1
 
+# These are deliberately quite long, so that the xxx_PROGRAMS definition
+# in Makefile.am below will be split on multiple lines, with the last
+# line containing only @substituted@ stuff that expands to empty (this is
+# required to expose the bug we are testing).
 v1=ABCDEFGHIJKLMNOPQRSTUVWX
 v2=ABCDEFGHIJKLMNOPQRSTUVWXY
 v3=ABCDEFGHIJKLMNOPQRSTUVWXYZ
-bs='\\' # Literal backslash for grep.
+
+# Literal backslash for use by grep.
+bs='\\'
 
 cat >> configure.in <<END
 AC_SUBST([A], [''])
-# These are deliberately quite long, so that the xxx_PROGRAMS definition
-# in Makefile.am below will be split on multiple lines, with the last
-# line
 AC_SUBST([$v1], [''])
 AC_SUBST([$v2], [''])
 AC_SUBST([$v3], [''])
@@ -61,7 +64,8 @@ END
 $ACLOCAL
 $AUTOCONF
 $AUTOMAKE
-$EGREP -n 'ABCD|am__empty' Makefile.in # For debugging,
+# For debugging.
+$EGREP -n 'ABCD|am__empty' Makefile.in
 # Sanity check.
 test `$EGREP -c "^[ address@hidden@ @address@hidden $tab]*$bs?$" Makefile.in` 
-eq 2
 
-- 
1.7.2.3




reply via email to

[Prev in Thread] Current Thread [Next in Thread]