[FYI] {testsuite-work} [PATCH] tests: remove redundant settings of `errexit' shell flag

[Stefano Lattarini]

* tests/amhello-binpkg.test: Do not set the `errexit' shell
flag, as it is already set by `tests/defs'.
* tests/amhello-cflags.test: Likewise.
* tests/amhello-cross-compile.test: Likewise.
* tests/ansi2knr-deprecation.test: Likewise.
* tests/autodist-no-duplicate.test: Likewise.
* tests/distcheck-configure-flags-am.test: Likewise.
* tests/distcheck-configure-flags-subpkg.test: Likewise.
* tests/distcheck-configure-flags.test: Likewise.
* tests/distcheck-hook.test: Likewise.
* tests/distcheck-hook2.test: Likewise.
* tests/parallel-tests-am_tests_environment.test: Likewise.
* tests/parallel-tests-harderror.test: Likewise.
* tests/parallel-tests-log-compiler-example.test: Likewise.
* tests/parallel-tests-log-override-1.test: Likewise.
* tests/parallel-tests-log-override-2.test: Likewise.
* tests/parallel-tests-log-override-recheck.test: Likewise.
* tests/primary-prefix-couples-documented-valid.test: Likewise.
* tests/primary-prefix-couples-force-valid.test: Likewise.
* tests/primary-prefix-invalid-couples.test: Likewise.
* tests/primary-prefix-valid-couples.test: Likewise.
* tests/remake-subdir-from-subdir.test: Likewise.
* tests/remake-subdir-gnu.test: Likewise.
* tests/remake-subdir-long-time.test: Likewise.
* tests/remake-subdir.test: Likewise.
* tests/remake-subdir2.test: Likewise.
* tests/silent-configsite.test: Likewise.
* tests/tests-environment-backcompat.test: Likewise.
---
 ChangeLog                                          |   32 ++++++++++++++++++++
 tests/amhello-binpkg.test                          |    2 -
 tests/amhello-cflags.test                          |    2 -
 tests/amhello-cross-compile.test                   |    2 -
 tests/ansi2knr-deprecation.test                    |    2 -
 tests/autodist-no-duplicate.test                   |    2 -
 tests/distcheck-configure-flags-am.test            |    2 -
 tests/distcheck-configure-flags-subpkg.test        |    2 -
 tests/distcheck-configure-flags.test               |    2 -
 tests/distcheck-hook.test                          |    2 -
 tests/distcheck-hook2.test                         |    2 -
 tests/parallel-tests-am_tests_environment.test     |    2 -
 tests/parallel-tests-harderror.test                |    2 -
 tests/parallel-tests-log-compiler-example.test     |    2 -
 tests/parallel-tests-log-override-1.test           |    2 -
 tests/parallel-tests-log-override-2.test           |    2 -
 tests/parallel-tests-log-override-recheck.test     |    2 -
 tests/primary-prefix-couples-documented-valid.test |    2 -
 tests/primary-prefix-couples-force-valid.test      |    2 -
 tests/primary-prefix-invalid-couples.test          |    2 -
 tests/primary-prefix-valid-couples.test            |    2 -
 tests/remake-subdir-from-subdir.test               |    2 -
 tests/remake-subdir-gnu.test                       |    2 -
 tests/remake-subdir-long-time.test                 |    2 -
 tests/remake-subdir.test                           |    2 -
 tests/remake-subdir2.test                          |    2 -
 tests/silent-configsite.test                       |    2 -
 tests/tests-environment-backcompat.test            |    2 -
 28 files changed, 32 insertions(+), 54 deletions(-)

diff --git a/ChangeLog b/ChangeLog
index 9b92575..56a1d7c 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,5 +1,37 @@
 2011-07-08  Stefano Lattarini  <address@hidden>
 
+       tests: remove redundant settings of `errexit' shell flag
+       * tests/amhello-binpkg.test: Do not set the `errexit' shell
+       flag, as it is already set by `tests/defs'.
+       * tests/amhello-cflags.test: Likewise.
+       * tests/amhello-cross-compile.test: Likewise.
+       * tests/ansi2knr-deprecation.test: Likewise.
+       * tests/autodist-no-duplicate.test: Likewise.
+       * tests/distcheck-configure-flags-am.test: Likewise.
+       * tests/distcheck-configure-flags-subpkg.test: Likewise.
+       * tests/distcheck-configure-flags.test: Likewise.
+       * tests/distcheck-hook.test: Likewise.
+       * tests/distcheck-hook2.test: Likewise.
+       * tests/parallel-tests-am_tests_environment.test: Likewise.
+       * tests/parallel-tests-harderror.test: Likewise.
+       * tests/parallel-tests-log-compiler-example.test: Likewise.
+       * tests/parallel-tests-log-override-1.test: Likewise.
+       * tests/parallel-tests-log-override-2.test: Likewise.
+       * tests/parallel-tests-log-override-recheck.test: Likewise.
+       * tests/primary-prefix-couples-documented-valid.test: Likewise.
+       * tests/primary-prefix-couples-force-valid.test: Likewise.
+       * tests/primary-prefix-invalid-couples.test: Likewise.
+       * tests/primary-prefix-valid-couples.test: Likewise.
+       * tests/remake-subdir-from-subdir.test: Likewise.
+       * tests/remake-subdir-gnu.test: Likewise.
+       * tests/remake-subdir-long-time.test: Likewise.
+       * tests/remake-subdir.test: Likewise.
+       * tests/remake-subdir2.test: Likewise.
+       * tests/silent-configsite.test: Likewise.
+       * tests/tests-environment-backcompat.test: Likewise.
+
+2011-07-08  Stefano Lattarini  <address@hidden>
+
        tests: portability fixes in tests on amhello examples
        * tests/amhello-binpkg.test: Don't use "tar xzf too.tag.gz" to
        extract a gzip-compressed tarball, that's unportable to some
diff --git a/tests/amhello-binpkg.test b/tests/amhello-binpkg.test
index 34600fe..cb95a06 100755
--- a/tests/amhello-binpkg.test
+++ b/tests/amhello-binpkg.test
@@ -19,8 +19,6 @@
 
 . ./defs || Exit 1
 
-set -e
-
 cp "$testsrcdir"/../doc/amhello-1.0.tar.gz . \
   || fatal_ "cannot get amhello tarball"
 
diff --git a/tests/amhello-cflags.test b/tests/amhello-cflags.test
index 56f7729..efff153 100755
--- a/tests/amhello-cflags.test
+++ b/tests/amhello-cflags.test
@@ -21,8 +21,6 @@
 required=gcc
 . ./defs || Exit 1
 
-set -e
-
 cp "$testsrcdir"/../doc/amhello-1.0.tar.gz . \
   || fatal_ "cannot get amhello tarball"
 
diff --git a/tests/amhello-cross-compile.test b/tests/amhello-cross-compile.test
index 6db91ba..bc31243 100755
--- a/tests/amhello-cross-compile.test
+++ b/tests/amhello-cross-compile.test
@@ -20,8 +20,6 @@
 required=i586-mingw32msvc-gcc
 . ./defs || Exit 1
 
-set -e
-
 cp "$testsrcdir"/../doc/amhello-1.0.tar.gz . \
   || fatal_ "cannot get amhello tarball"
 
diff --git a/tests/ansi2knr-deprecation.test b/tests/ansi2knr-deprecation.test
index 543d9c6..c04c6a8 100755
--- a/tests/ansi2knr-deprecation.test
+++ b/tests/ansi2knr-deprecation.test
@@ -19,8 +19,6 @@
 
 . ./defs || Exit 1
 
-set -e
-
 warn_rx='automatic de-ANSI-fication.*deprecated'
 
 cat >> configure.in <<'END'
diff --git a/tests/autodist-no-duplicate.test b/tests/autodist-no-duplicate.test
index 81464c0..1109129 100755
--- a/tests/autodist-no-duplicate.test
+++ b/tests/autodist-no-duplicate.test
@@ -19,8 +19,6 @@
 
 . ./defs || Exit 1
 
-set -e
-
 re='Files .*automatically distributed.*if found'
 
 # The automake manual states that the list of automatically-distributed
diff --git a/tests/distcheck-configure-flags-am.test 
b/tests/distcheck-configure-flags-am.test
index a5cab6a..40c3a79 100755
--- a/tests/distcheck-configure-flags-am.test
+++ b/tests/distcheck-configure-flags-am.test
@@ -19,8 +19,6 @@
 
 . ./defs || Exit 1
 
-set -e
-
 cat >> configure.in << 'END'
 AC_ARG_ENABLE([success], [], [success=$enableval], [success=no])
 AS_IF([test $success = yes && test "$sentence" = 'it works :-)'],
diff --git a/tests/distcheck-configure-flags-subpkg.test 
b/tests/distcheck-configure-flags-subpkg.test
index 695b47c..5c9a320 100755
--- a/tests/distcheck-configure-flags-subpkg.test
+++ b/tests/distcheck-configure-flags-subpkg.test
@@ -22,8 +22,6 @@
 
 . ./defs || Exit 1
 
-set -e
-
 cat >> configure.in << 'END'
 AC_CONFIG_SUBDIRS([subpkg])
 if test $dc != ok || test $am_dc != ok; then
diff --git a/tests/distcheck-configure-flags.test 
b/tests/distcheck-configure-flags.test
index 117d83c..9a2eb4c 100755
--- a/tests/distcheck-configure-flags.test
+++ b/tests/distcheck-configure-flags.test
@@ -18,8 +18,6 @@
 
 . ./defs || Exit 1
 
-set -e
-
 cat >> configure.in << 'END'
 AC_ARG_ENABLE([success], [], [success=$enableval], [success=no])
 AS_IF([test $success = yes && test "$sentence" = 'it works :-)'],
diff --git a/tests/distcheck-hook.test b/tests/distcheck-hook.test
index 9a2c384..16b151e 100755
--- a/tests/distcheck-hook.test
+++ b/tests/distcheck-hook.test
@@ -18,8 +18,6 @@
 
 . ./defs || Exit 1
 
-set -e
-
 cat >> configure.in << 'END'
 AC_OUTPUT
 END
diff --git a/tests/distcheck-hook2.test b/tests/distcheck-hook2.test
index befc1d6..7a20156 100755
--- a/tests/distcheck-hook2.test
+++ b/tests/distcheck-hook2.test
@@ -20,8 +20,6 @@
 
 . ./defs || Exit 1
 
-set -e
-
 cat >> configure.in << 'END'
 AC_CONFIG_SUBDIRS([subpkg])
 AC_OUTPUT
diff --git a/tests/parallel-tests-am_tests_environment.test 
b/tests/parallel-tests-am_tests_environment.test
index 072e614..eff02a6 100755
--- a/tests/parallel-tests-am_tests_environment.test
+++ b/tests/parallel-tests-am_tests_environment.test
@@ -20,8 +20,6 @@
 parallel_tests=yes
 . ./defs || Exit 1
 
-set -e
-
 cat >> configure.in << 'END'
 AC_PROG_MKDIR_P
 AC_OUTPUT
diff --git a/tests/parallel-tests-harderror.test 
b/tests/parallel-tests-harderror.test
index 8680e29..dedef36 100755
--- a/tests/parallel-tests-harderror.test
+++ b/tests/parallel-tests-harderror.test
@@ -19,8 +19,6 @@
 parallel_tests=yes
 . ./defs || Exit 1
 
-set -e
-
 cat >> configure.in << 'END'
 AC_CONFIG_FILES([sub/Makefile])
 AC_OUTPUT
diff --git a/tests/parallel-tests-log-compiler-example.test 
b/tests/parallel-tests-log-compiler-example.test
index 746c128..95013f1 100755
--- a/tests/parallel-tests-log-compiler-example.test
+++ b/tests/parallel-tests-log-compiler-example.test
@@ -21,8 +21,6 @@ parallel_tests=yes
 required=python
 . ./defs || Exit 1
 
-set -e
-
 cat >> configure.in <<END
 AC_SUBST([PERL], ['$PERL'])
 AM_PATH_PYTHON
diff --git a/tests/parallel-tests-log-override-1.test 
b/tests/parallel-tests-log-override-1.test
index 6e98380..988e424 100755
--- a/tests/parallel-tests-log-override-1.test
+++ b/tests/parallel-tests-log-override-1.test
@@ -19,8 +19,6 @@
 parallel_tests=yes
 . ./defs || Exit 1
 
-set -e
-
 cat >> configure.in <<'END'
 AC_OUTPUT
 END
diff --git a/tests/parallel-tests-log-override-2.test 
b/tests/parallel-tests-log-override-2.test
index 649360c..b790c41 100755
--- a/tests/parallel-tests-log-override-2.test
+++ b/tests/parallel-tests-log-override-2.test
@@ -21,8 +21,6 @@
 parallel_tests=yes
 . ./defs || Exit 1
 
-set -e
-
 cat >> configure.in <<'END'
 AC_OUTPUT
 END
diff --git a/tests/parallel-tests-log-override-recheck.test 
b/tests/parallel-tests-log-override-recheck.test
index 8a50d29..0739cbe 100755
--- a/tests/parallel-tests-log-override-recheck.test
+++ b/tests/parallel-tests-log-override-recheck.test
@@ -20,8 +20,6 @@
 parallel_tests=yes
 . ./defs || Exit 1
 
-set -e
-
 cat >> configure.in <<'END'
 AC_OUTPUT
 END
diff --git a/tests/primary-prefix-couples-documented-valid.test 
b/tests/primary-prefix-couples-documented-valid.test
index 645f318..134c212 100755
--- a/tests/primary-prefix-couples-documented-valid.test
+++ b/tests/primary-prefix-couples-documented-valid.test
@@ -20,8 +20,6 @@
 
 . ./defs || Exit 1
 
-set -e
-
 cat >> configure.in <<'END'
 AC_PROG_CC
 AC_PROG_RANLIB
diff --git a/tests/primary-prefix-couples-force-valid.test 
b/tests/primary-prefix-couples-force-valid.test
index 315ee4e..b462a7d 100755
--- a/tests/primary-prefix-couples-force-valid.test
+++ b/tests/primary-prefix-couples-force-valid.test
@@ -26,8 +26,6 @@
 required=cc
 . ./defs || Exit 1
 
-set -e
-
 cat >> configure.in <<'END'
 AC_PROG_CC
 AC_PROG_RANLIB
diff --git a/tests/primary-prefix-invalid-couples.test 
b/tests/primary-prefix-invalid-couples.test
index 88e0817..4791707 100755
--- a/tests/primary-prefix-invalid-couples.test
+++ b/tests/primary-prefix-invalid-couples.test
@@ -22,8 +22,6 @@
 
 . ./defs || Exit 1
 
-set -e
-
 oIFS=$IFS # Saved for later.
 
 : > ltmain.sh
diff --git a/tests/primary-prefix-valid-couples.test 
b/tests/primary-prefix-valid-couples.test
index f326808..0d0a88c 100755
--- a/tests/primary-prefix-valid-couples.test
+++ b/tests/primary-prefix-valid-couples.test
@@ -19,8 +19,6 @@
 
 . ./defs || Exit 1
 
-set -e
-
 cat >> configure.in <<'END'
 AC_PROG_CC
 AC_PROG_RANLIB
diff --git a/tests/remake-subdir-from-subdir.test 
b/tests/remake-subdir-from-subdir.test
index f844550..8f4a180 100755
--- a/tests/remake-subdir-from-subdir.test
+++ b/tests/remake-subdir-from-subdir.test
@@ -21,8 +21,6 @@
 
 . ./defs || Exit 1
 
-set -e
-
 cat >> configure.in <<'END'
 m4_include([subdirs.m4])
 AC_SUBST([MAGIC], [magic])
diff --git a/tests/remake-subdir-gnu.test b/tests/remake-subdir-gnu.test
index 7865c20..bda1ac7 100755
--- a/tests/remake-subdir-gnu.test
+++ b/tests/remake-subdir-gnu.test
@@ -23,8 +23,6 @@
 required=GNUmake
 . ./defs || Exit 1
 
-set -e
-
 magic1='::MagicString::One::'
 magic2='__MagicString__Two__'
 
diff --git a/tests/remake-subdir-long-time.test 
b/tests/remake-subdir-long-time.test
index 18ba732..40f3e5f 100755
--- a/tests/remake-subdir-long-time.test
+++ b/tests/remake-subdir-long-time.test
@@ -23,8 +23,6 @@
 
 . ./defs || Exit 1
 
-set -e
-
 cat > configure.in <<END
 AC_INIT([$me], [1.0])
 AM_INIT_AUTOMAKE([foreign -Wall -Werror])
diff --git a/tests/remake-subdir.test b/tests/remake-subdir.test
index 3ccfee5..2df1e6f 100755
--- a/tests/remake-subdir.test
+++ b/tests/remake-subdir.test
@@ -21,8 +21,6 @@
 
 . ./defs || Exit 1
 
-set -e
-
 if using_gmake; then
   remake=$MAKE
 else
diff --git a/tests/remake-subdir2.test b/tests/remake-subdir2.test
index dcf306e..a8f7556 100755
--- a/tests/remake-subdir2.test
+++ b/tests/remake-subdir2.test
@@ -21,8 +21,6 @@
 
 . ./defs || Exit 1
 
-set -e
-
 magic1='::MagicString::One::'
 magic2='__MagicString__Two__'
 
diff --git a/tests/silent-configsite.test b/tests/silent-configsite.test
index a0255f5..a3348e9 100755
--- a/tests/silent-configsite.test
+++ b/tests/silent-configsite.test
@@ -20,8 +20,6 @@
 
 . ./defs || Exit 1
 
-set -e
-
 cat >> configure.in <<'EOF'
 AM_SILENT_RULES
 AC_OUTPUT
diff --git a/tests/tests-environment-backcompat.test 
b/tests/tests-environment-backcompat.test
index 6749bc2..08daa09 100755
--- a/tests/tests-environment-backcompat.test
+++ b/tests/tests-environment-backcompat.test
@@ -22,8 +22,6 @@
 parallel_tests=no
 . ./defs || Exit 1
 
-set -e
-
 cat >> configure.in <<END
 AC_SUBST([PERL], ['$PERL'])
 AC_OUTPUT
-- 
1.7.2.3