[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Alternatives for check8.test...

From: Stefano Lattarini
Subject: Re: Alternatives for check8.test...
Date: Thu, 02 Feb 2012 21:37:16 +0100

On 02/02/2012 09:16 PM, Peter Rosin wrote:
> The following is what I pushed (to maint).

> Subject: [PATCH] tests: do not clobber the modified CC
> If CC is originally a losing compiler, AM_PROG_CC_C_O will
> modify CC.  "$MAKE -e" will then clobber this modified CC
> and reintroduce the raw losing compiler causing the test
> to fail, as subdir-objects is in effect.
> tests/check8.test: Drop -e from the $MAKE invocation, since
> AM_COLOR_TESTS is not specified in the Makefile and -e is
> therefore not needed.
And nice commit message as well (one minor nit though: I would
have written "CC originally points to a losing compiler" rather
than "CC is originally a losing compiler"; but no big deal).


reply via email to

[Prev in Thread] Current Thread [Next in Thread]