[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: makefile-deps.test false positive, how to handle?

From: Peter Rosin
Subject: Re: makefile-deps.test false positive, how to handle?
Date: Tue, 14 Feb 2012 13:56:27 +0100
User-agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:9.0) Gecko/20111222 Thunderbird/9.0.1

Stefano Lattarini skrev 2012-02-14 13:41:
> On 02/14/2012 01:34 PM, Peter Rosin wrote:
>> Hi!
>> Commit v1.11-685-g947ce0e of 07-02-2012 added code for am__make_dryrun
>> that triggers a false positive in makefile-deps.test.
> Please see:
>   <>
> and follow-up messages.
> BTW, this message of yours definitively proves that Jim was right, and that
> we need the KFAIL_TESTS workaround ASAP.

No rush from my point of view, no real harm done to me...

>> I see two alternative approaches, which should I commit?
>> 1. Avoid the check in the test
>> From: Peter Rosin <address@hidden>
>> Date: Tue, 14 Feb 2012 12:55:32 +0100
>> Subject: [PATCH] fixup: do not tickle makefile-deps.test with the 
>> make_dryrun code
>> * lib/am/ (am__make_dryrun): Avoid code matching
>> '^ *:' in the Makefile, as that tickles makefile-deps.test.
> I'd go with this FTM.  Feel free to push it when you want.
> Thanks, and again, sorry for the confusion,
>   Stefano

Crap, I did read that thread, but not closely enough apparently.  And
I didn't search the archives before posting.  So, my fault too.

Pushed to maint now, so no more victims hopefully :-)


reply via email to

[Prev in Thread] Current Thread [Next in Thread]