[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] maint: support amending the generated ChangeLog, and fix a t
Re: [PATCH] maint: support amending the generated ChangeLog, and fix a typo
Fri, 17 Feb 2012 09:33:12 +0100
On 02/17/2012 08:55 AM, Peter Rosin wrote:
> * Makefile.am (gitlog_to_changelog_options): Add support for
> amending the generated ChangeLog.
> * lib/git-log-fix: New file with things to amend to the generated
> ChangeLog, starting with a fix for a typo in v1.11-1963-g3b369e6
> from yesterday.
> Makefile.am | 4 +++-
> lib/git-log-fix | 8 ++++++++
> 2 files changed, 11 insertions(+), 1 deletions(-)
> create mode 100644 lib/git-log-fix
> I noticed a typo in a commit message and thought I'd start the
> ChangeLog amend thing. Is it ok to put the fixes in lib/git-log-fix?
Hmm.... What about placing them in a .git-log-fix or .gitlogfix file
in the top-level directory instead? This seem more appropriate to me.
> I didn't think the fixes should be distributed, since the ChangeLog
> is already generated in that case and "git log" is kind of useless
> without a repo.
While this is true, I'd like to distribute all the files that might
interest an hypotetical "curious user" who's gotten automake though
a distribution tarball -- even if such files are actually usable only
from a git checkout. Would that be OK to you?
> Also, other projects don't seem to do it...
> Ok for master?
OK once the issues raised above has been addressed (or refuted).
> Or should this be two patches, with the infrastructure commited to
> maint and the fixlet commited to master?
Nah, don't bother about maint anymore but for the most basic bug
fixes... Let's point straight to 1.12 instead :-)