Re: [PATCH] tests: avoid spurious failure when gcj is not installed

[Stefano Lattarini]

On 02/25/2012 02:32 PM, Jim Meyering wrote:
> Stefano Lattarini wrote:
> ...
>> The patch is OK, of course.  Extra kudos if you add a reference in the
>> commit message to the commit where I broke the tests.
> 
> Hi Stefano,
> Thanks for the explanation.
> 
> Here you go:
>
> [BTW, if you like gitk's highlighting of SHA1 strings in logs, and
> compile your own version of git once in a while, you might want to
> carry this git patch:  http://marc.info/?t=132352993500001&r=1&w=2
> It makes gitk also highlight the SHA1 part of more descriptive
> strings like v1.11-2019-g4d2bf42 below.  This shows what it looks like:
> http://meyering.net/code/gitk/gitk-highlight-git-describe-SHA1.jpg ]
>
Thanks for the tip, but:

 - I tend to use "qgit", not "gitk"

 - I don't compile git myself, but rather I use the Debian packaged one

So I'll just live with less automatic highlighting :-)

> From 9888205813e24281527448d408b2e4e5075e2026 Mon Sep 17 00:00:00 2001
> From: Jim Meyering <address@hidden>
> Date: Sat, 25 Feb 2012 12:37:25 +0100
> Subject: [PATCH] tests: avoid spurious failure when gcj is not installed
> 
> * tests/defs-static.in (GNU_GCJ, GNU_GCJFLAGS): Define.
> * tests/Makefile.am (do_subust): Add those to the list of
> substituted symbols.
> Introduced via the previous commit, v1.11-2019-g4d2bf42.
>
One ludicrously minor nit: we should put references to bug reports,
names of people to thanks, or old commits that introduced a regression
*before* the list of touched files, and always separated by a leading
and a trailing blank line; like this:

    docs: remove reference to lzma support, it has been removed

    Support for lzma compression in distribution tarball has been
    removed in commit 'v1.11-1674-g02e9072' of 01-01-2012, "dist:
    remove support for lzma (superseded by xz and lzip)", but was
    still documented in the manual.

    * doc/automake.texi: Remove references to the 'dist-lzma' option
    and to the lzma compression support.

or this:

    tests: fix a timestamp issue, and other minor buglets

    Reported by Panther Martin in automake bug#10848.

    * tests/conffile-leading-dot.test: Add a proper '$sleep' invocation,
    to avoid spurious failures on fast systems without sub-second
    timestamp resolutions.  Add other minor related and unrelated
    improvements and fixlets since we are at it.

Thanks,
  Stefano