Re: [PATCH] tests: explicitly state that our lexers do not require unistd.h

[Stefano Lattarini]

Hi Peter.

On 03/05/2012 03:10 PM, Peter Rosin wrote:
> By default, GNU flex generates code that is dependent on unistd.h,
> which is not portable to non-ANSI systems causing spurious test
> failures.
> 
> * tests/cond35.test (tscan.l): Define YY_NO_UNISTD_H.
> * tests/lex-clean.test (lexer.l): Likewise.
> * tests/lex-depend-cxx.test (joe.ll): Likewise.
> * tests/lex-depend.test (joe.l): Likewise.
> * tests/lex-lib-external.test (foo.l): Likewise.
> ...
>  19 files changed, 65 insertions(+), 0 deletions(-)
> 
> Hi!
> 
> Ok for master?
>
Yes...  but I'd like to see a little addition squashed-in if you can: a
new entry in 'tests/README' explaining that a "#define YY_NO_UNISTD_H"
is needed in lex input files, and why it is so.

Thanks,
  Stefano