Re: [PATCH 0/5] Convert automake testsuite to the use of a POSIX shell

[Stefano Lattarini]

Hi Eric.

On 05/01/2012 06:18 PM, Eric Blake wrote:
> On 05/01/2012 10:04 AM, Stefano Lattarini wrote:
>> This patches are the first step in that direction.  I will push in 72 hours
>> if there is no objection.
> 
> Heads up - I'd like to review this series closely, but am not sure I
> will finish my review in 72 hours.
>
I'll wait more time than, a review form you is certainly worth more
delay.  Thanks.

> Just so I know what to look for - is this just the use of the POSIX
> shell in the automake testsuite, but that Makefile.in generated by
> Automake still work with Solaris /bin/sh?
>
Yes (at least, until Autoconf decides that is time to start requiring
a POSIX shell for the configure scripts it generates, and sets
CONFIG_SHELL accordingly ;-)

> Also, I'm assuming that you are using hand-written shell scripts to
> get to this point, rather than using autoconf's m4sh language to
> build up your testsuite scripts?
>
Our test scripts are not build, but hand-written (OK, some are
automatically generated, but even those are thin layers around other
test scripts, or some '.sh' "driver" that runs most of the actual
checks).  So an use of m4sh is out of question (too much churn and
risks of regression).  Plus, it wouldn't help with many of the most
annoying bugs (i.e., Solaris /bin/sh "optimizing" away every ":"
command after the firs one in a loop, even if they are redirected).

Regards,
  Stefano