automake-patches
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 2/5] configure: search a sturdy POSIX shell to be used in the


From: Stefano Lattarini
Subject: Re: [PATCH 2/5] configure: search a sturdy POSIX shell to be used in the testsuite
Date: Wed, 02 May 2012 11:30:32 +0200

On 05/01/2012 06:04 PM, Stefano Lattarini wrote:
> * configure.ac: Add code (partially inspired to checks in gnulib's
> 'tests/init.sh') to search for a good-enough, not-buggy POSIX/XSI
> shell to be used in our testsuite.  Accordingly AC_SUBSTitute the
> variable 'AM_TEST_RUNNER_SHELL'.
> * NEWS: Update.
> 
Oops, I had forgotten to update the patch to quote 'like this', not
`like this'.  Consider the diff below squashed in, and sorry for the
noise.

diff --git a/configure.ac b/configure.ac
index 3700c8f..a7368cf 100644
--- a/configure.ac
+++ b/configure.ac
@@ -253,16 +253,16 @@ exit 77" >&AS_MESSAGE_LOG_FD 2>&1; test $? -eq 77; }
 # -----------------------------------------
 #
 # Check if the given shell is good enough to run our test scripts.
-# Inspired to gnulib's `tests/init.sh'.
+# Inspired to gnulib's 'tests/init.sh'.
 #
-# We require POSIX and XSI features (e.g., `$(...)' for command
-# substitutions, `$((...))' for shell arithmetic, and support for
-# ${var#...} and ${var%...} parameter expansions).
+# We require POSIX and XSI features (e.g., '$(...)' for command
+# substitutions, '$((...))' for shell arithmetic, and support for
+# '${var#...}' and '${var%...}' parameter expansions).
 #
-# We require that the shell can correctly trap EXIT when `set -e' is in
+# We require that the shell can correctly trap EXIT when 'set -e' is in
 # effect (OSF1/Tru64 sh failed to do so, see commit v1.10b-52-g9fe8259).
 #
-# We also prefer shells that, when `set -x' is in effect, do not also
+# We also prefer shells that, when 'set -x' is in effect, do not also
 # redirect traces upon stderr redirections.  For example,
 #  $ set -x; echo x 2>file
 # would emit "+ echo x" into file with older zsh versions.  Similarly,
@@ -273,7 +273,7 @@ exit 77" >&AS_MESSAGE_LOG_FD 2>&1; test $? -eq 77; }
 # Finally, we look for weird bugs and portability problems mentioned in
 # the Autoconf manual, and reject shells that suffers from them. (TODO)
 #
-# Use `$am_score' to indicate the degree of acceptability of the shell.
+# Use '$am_score' to indicate the degree of acceptability of the shell.
 # A score of "10" means that the shell is good enough for our needs;
 # a score of "9" means that the shell has some minor bugs or limitation,



reply via email to

[Prev in Thread] Current Thread [Next in Thread]