Re: [PATCH 3/3] ylwrap: rename header inclusion in generated parsers

[Stefano Lattarini]

Hi Akim.

The commit 'a4fd5c7c2cd2a2b626c670741313f0a94c38c529' that you've pushed
is broken; it defines '$rename_sed', but do not actually use it, and
thus does not fix the bug it says it fixes.  Only the later commit
cd94deae0c8abccbd33e3d03983f4a607fafb4ad (that should be just a cosmetic
or style one according to its commit message) starts using '$rename_sed':

  @@ -207,8 +207,8 @@ if test $ret -eq 0; then
         FROM=`guard "$from"`
         TARGET=`guard "$to"`

  -      sed -e "/^#/!b" -e "s,$input_rx,$input_sub_rx," -e "s,$from,$to," \
  -          -e "s,$FROM,$TARGET," "$from" >"$target" || ret=$?
  +      sed -e "/^#/!b" -e "s|$input_rx|$input_sub_rx|" -e "$rename_sed" \
  +          -e "s|$FROM|$TARGET|" "$from" >"$target" || ret=$?

Could you please fix the situation please?  Also, because we expect the
commit 'a4fd5c7c2cd2a2b626c670741313f0a94c38c529' to fix the test
'yacc-bison-skeleton.sh', it should be amended so that XFAIL_TESTS does
not contain the fixed test anymore; in addition to avoiding an XPASS,
that makes clear that the commit is fixing a pre-existing bug as well.

Thanks,
  Stefano