Re: [RFC 05/20] depcomp: safer quoting in variable expansion

[Pavel Raiskup]

Hi,

On Thu, 2012-10-18 at 22:40 +0200, Stefano Lattarini wrote:
> * lib/depcomp (pgcc): Here.  Probably not needed, but since the
> rest of the script seems to employ proper quoting, better to be
> consistent.
> 
> Signed-off-by: Stefano Lattarini <address@hidden>
> ---
>  lib/depcomp | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/lib/depcomp b/lib/depcomp
> index dbcacd0..2f0c6c5 100755
> --- a/lib/depcomp
> +++ b/lib/depcomp
> @@ -358,24 +358,24 @@ pgcc)
>    lockdir=$base.d-lock
>    trap "
>      echo '$0: caught signal, cleaning up...' >&2
> -    rmdir $lockdir
> +    rmdir '$lockdir'

here seems to be problem,

thanks,
Pavel

>      exit 1
>    " 1 2 13 15
>    numtries=100
>    i=$numtries
>    while test $i -gt 0 ; do
>      # mkdir is a portable test-and-set.
> -    if mkdir $lockdir 2>/dev/null; then
> +    if mkdir "$lockdir" 2>/dev/null; then
>        # This process acquired the lock.
>        "$@" -MD
>        stat=$?
>        # Release the lock.
> -      rmdir $lockdir
> +      rmdir "$lockdir"
>        break
>      else
>        ## the lock is being held by a different process,
>        ## wait until the winning process is done or we timeout
> -      while test -d $lockdir && test $i -gt 0; do
> +      while test -d "$lockdir" && test $i -gt 0; do
>          sleep 1
>          i=`expr $i - 1`
>        done