Re: [PATCH 6/6] aclocal: avoid spurious warnings from autom4te with AC_CONFIG_MACRO_DIRS

[Eric Blake]

On 11/07/2012 04:23 PM, Stefano Lattarini wrote:
>> Allowing file inclusion as the witness of whether to warn would work
>> even for older autoconf (where including the file has no effect), rather
>> than the current situation of warning about an unknown option.
>>
> Good thinking.  And since aclocal is not expected to read any input from
> stdin anyway, such macro definition could be passed directly from the
> command line, as in:
> 
>   $ cat x
>   A
>   $ echo "define(A,B)dnl" | autom4te - x
>   B
> 
> saving us from the need to handle temporary files.

Ohh, interesting idea.  I had been battling with trying to change the
language definitions in autoconf's lib/autom4te.in, by adding another
frozen .m4f file into the mix only when needed, precisely because there
is no way to pass a -Dmacro=foo on the autom4te command line; but your
idea of concatenating stdin containing the needed define is more elegant
and makes my efforts much easier.

> 
> So, should I attempt a patch along this new directions, or are you going
> to post one yourself? (In which case I'll save myself some time and avoid
> duplicate efforts, especially considering that a patch from you will
> certainly be better then mine ;-)

Sounds like enough is waiting on me that I need to carve out a full day
for autoconf work.  You've convinced me - I'll have a patches posted to
autoconf, including the best parts of what you have posted and were
waiting for a 2-day review window, within the next 48 hours.

-- 
Eric Blake   address@hidden    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

signature.asc
Description: OpenPGP digital signature