[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] PATH: use double quote
|
From: |
Eric Blake |
|
Subject: |
Re: [PATCH] PATH: use double quote |
|
Date: |
Mon, 22 Sep 2014 09:29:43 -0600 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.1.0 |
On 09/22/2014 01:12 AM, KO Myung-Hun wrote:
> * Makefile.am: Subject.
That's a very poor changelog entry. I'll leave it up to the automake
maintainer if it should be improved, though.
> * t/Makefile.inc: Likewise.
> ---
> Makefile.am | 2 +-
> t/Makefile.inc | 4 ++--
> 2 files changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/Makefile.am b/Makefile.am
> index 7e1c748..07c52c4 100644
> --- a/Makefile.am
> +++ b/Makefile.am
> @@ -72,7 +72,7 @@ generated_file_finalize = $(AM_V_at) \
> # For some tests or targets, we need to have the just-build automake and
> # aclocal scripts avaiable on PATH.
> extend_PATH = \
> - { PATH='$(abs_builddir)/t/wrap'$(PATH_SEPARATOR)$$PATH && export PATH; }
> + { PATH="$(abs_builddir)/t/wrap$(PATH_SEPARATOR)$$PATH" && export PATH; }
Why are you changing this? I see no difference in the resulting shell
syntax, except that backslashes in $(abs_builddir) are now handled
differently. You need a lot more justification for WHY this patch is
necessary.
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature