[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: 10-check-am.patch

From: Tom Tromey
Subject: Re: 10-check-am.patch
Date: 28 Jan 2001 18:57:20 -0700

>>>>> "Akim" == Akim Demaille <address@hidden> writes:

Akim>   * (handle_phony): Sort.
Akim>   * (file_contents_with_transform): Catch `.PHONY:'.
Akim>   * New file. wasn't in the patch.  However, I trust it is just an
extraction from handle_tests.

Please add a ChangeLog entry for handle_tests.  Also, the ChangeLog
entry shouldn't repeat `':

        * (handle_phony): Sort.
        (file_contents_with_transform): Catch `.PHONY:'.
        * New file.

(This is an absurdly nitty nit.)

Finally, could you move the `Solaris 2.7' comment from handle_tests
into and make it into a `##' comment?  In fact, move it to
just above the line it comments.

It is fine to `cvs add' a file so that `cvs diff -N' creates the
correct diff.  This applies generally -- if you don't have cvs write
access there is a script you can get that will do a phony `cvs add' by
manipulating CVS/Entries.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]