[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: 82-lang-finish.patch
From: |
Tom Tromey |
Subject: |
Re: 82-lang-finish.patch |
Date: |
10 Apr 2001 15:20:15 -0600 |
>>>>> "Akim" == Akim Demaille <address@hidden> writes:
Akim> * automake.in: (Language): Add attribute `_finish'.
Akim> (&finish): New.
Akim> (Automake): Adjust.
Akim> (&lang_header_finish, &lang_yaccxx_finish, &lang_lexxx_finish)
Akim> (&lang_asm_finish): Remove.
I'm not so sure about this patch.
These are precisely the kinds of things I would like to turn into
methods. What you're doing is sort of like a method, but uglier to my
eyes. Why not make real packages?
Akim> - 'extensions' => ['s', 'S']));
Akim> + 'extensions' => ['s', 'S'],
Akim> + # We need the C code for assembly.
Akim> + '_finish' => \&lang_c_finish));
I have a mild dislike for this.
If `finish' were a method then we could simply inherit it.
Tom
- Re: 82-lang-finish.patch,
Tom Tromey <=
- Re: 82-lang-finish.patch, akim, 2001/04/10
- Re: 82-lang-finish.patch, Tom Tromey, 2001/04/10
- Re: 82-lang-finish.patch, Akim Demaille, 2001/04/11
- Re: 82-lang-finish.patch, Tom Tromey, 2001/04/11
- Re: 82-lang-finish.patch, akim, 2001/04/11
- Re: 82-lang-finish.patch, akim, 2001/04/11
- Re: 82-lang-finish.patch, Tom Tromey, 2001/04/12