Re: [Bino-list] lirc

[Robert Pliszko]

Hi Martin

On 18.05.2011 12:11, Martin Lambers wrote:
> Hi Robert!
> > Before I will add bug on bug-track I would like how use these commands
> > on config file. I've tried different configurations and "play", "stop"
> > "pause" didn't work.
> > Examples my config files:
> >
> > ##########################
> > ...
> > begin
> >    prog = bino
> >    button = STOP
> >    config = stop
> > end
> >
> > begin
> >    prog = bino
> >    button = PLAY
> >    config = play
> > end
> >
> > begin
> >    prog = bino
> >    button = PAUSE
> >    config = pause
> > end
> > ...
> > ##############################
>
> This should work (it works for me), but note that you need to restart
> Bino when you changed your LIRC configuration files. Bino does not
> re-load it automatically.
>
> Martin

Martin, I'm using bino without gui with "-n" option (I run bino via 
xbmc). I've checked it, I modified lirc.cpp (I'm not programmer on C and 
C++):

...
    else if (t == "play")
    {
        if (!_playing)
        {
            msg::wrn(_("Start playing...));
            c = command(command::toggle_play);
        }
        else if (_pausing)
        {
            msg::wrn(_("Pause..."));
            c = command(command::toggle_pause);
        }
        else
        {
            msg::wrn(_("Do nothing..."));
            c = command(command::noop);
        }
    }
...

As you see I added msg:wrn(...). So, If I run bino with gui:

address@hidden ~]$ bino
bino: [wrn] FFmpeg: [matroska,webm @ 0xa902b80] Estimating duration from 
bitrate, this may be inaccurate
bino: [wrn] FFmpeg: [matroska,webm @ 0xa9740d0] Estimating duration from 
bitrate, this may be inaccurate
bino: [wrn] Start playing..., _playing =
bino: [wrn] FFmpeg: [matroska,webm @ 0xa902b80] Estimating duration from 
bitrate, this may be inaccurate
bino: [wrn] FFmpeg: [matroska,webm @ 0xafa9300] Estimating duration from 
bitrate, this may be inaccurate
bino: [wrn] Do nothing...
bino: [wrn] Stop...
bino: [wrn] Start playing...
bino: [wrn] FFmpeg: [matroska,webm @ 0xa902b80] Estimating duration from 
bitrate, this may be inaccurate
bino: [wrn] FFmpeg: [matroska,webm @ 0xa964f20] Estimating duration from 
bitrate, this may be inaccurate
bino: [wrn] Do nothing...
bino: [wrn] Pause...
bino: [wrn] Pause...
bino: [wrn] Video: późnienie 1,61423 sekund; odrzucanie następnej ramki.
bino: [wrn] Video: późnienie 1,57323 sekund; odrzucanie następnej ramki.
bino: [wrn] Video: późnienie 1,53123 sekund; odrzucanie następnej ramki.
bino: [wrn] Pause...
bino: [wrn] Pause...
bino: [wrn] Stop...

It's working perfectly! BUT! If I run bino without gui:

address@hidden ~]$ bino --input=separate-left-right 
/home/plesken/Wideo/3D/Clash\ Of\ The\ 
Titans/Clash.Of.The.Titans.3DBD.LEFT.1080p.D.D.5.1.x264-SWEMUX.mkv 
/home/plesken/Wideo/3D/Clash\ Of\ The\ 
Titans/Clash.Of.The.Titans.3DBD.RIGHT.1080p.D.D.5.1.x264-SWEMUX.mkv 
--output=red-cyan-dubois --audio=1 --subtitle=1 -n 
--lirc-config=/home/plesken/.lircrc
bino: [wrn] FFmpeg: [matroska,webm @ 0x997cb90] Estimating duration from 
bitrate, this may be inaccurate
bino: [inf] /home/plesken/Wideo/3D/Clash Of The 
Titans/Clash.Of.The.Titans.3DBD.LEFT.1080p.D.D.5.1.x264-SWEMUX.mkv:
bino: [inf]     Strumień video 0: 1920x1080, 1,78:1 / 
1920x1080-1,78:1-yuv420p-601-mpeg-l, 6367,58 sekund
bino: [inf]         Użyj do 2 wątków do dekodowania.
bino: [inf]     Strumień audio 0: nieznany, 6 ch., 48 kHz, 16 bit / 
nieznany-6-48000-s16, 6367,58 sekund
bino: [wrn] FFmpeg: [matroska,webm @ 0x99fabe0] Estimating duration from 
bitrate, this may be inaccurate
bino: [inf] /home/plesken/Wideo/3D/Clash Of The 
Titans/Clash.Of.The.Titans.3DBD.RIGHT.1080p.D.D.5.1.x264-SWEMUX.mkv:
bino: [inf]     Strumień video 0: 1920x1080, 1,78:1 / 
1920x1080-1,78:1-yuv420p-601-mpeg-l, 6367,36 sekund
bino: [inf]         Użyj do 2 wątków do dekodowania.
bino: [inf] Wejście:
bino: [inf]     Video #1/2: 1920x1080, 1,78:1: 
1920x1080-1,78:1-yuv420p-601-mpeg-l
bino: [inf]     Video #2/2: 1920x1080, 1,78:1: 
1920x1080-1,78:1-yuv420p-601-mpeg-l
bino: [inf]     Audio nieznany, 6 ch., 48 kHz, 16 bit: nieznany-6-48000-s16
bino: [inf]     Brak napisów.
bino: [inf]     Czas trwania: 6367,36 sekund
bino: [inf]     Układ stereo: separate-left-right
bino: [wrn] Video: późnienie 0,037791 sekund; odrzucanie następnej ramki.
bino: [wrn] Do nothing...
bino: [wrn] Do nothing...
bino: [wrn] Do nothing...
bino: [wrn] Do nothing...
bino: [wrn] Start playing...
address@hidden ~]$

You see the warn message is "Do nothing..." - I clicked on "pause", 
"stop" few times. When I clicked on "play" the bino closed down and warn 
was "Start playing...". I've noticed the problem is on "_playing" 
variable on the lirc.cpp which is not set.

...
else if (t == "play")
    {
        if (!_playing) {
      ^^^^^^^^^^^^^^^^^^^^
...

If we run bino with gui the variable _playing automaticaly set on 
"false", and when we push button play this variable change to "true" and 
rest of them work correctly.

If we run bino without gui the variable is set on "false", but movie is 
playing, so we can't use "pause" and "stop", before click on remote 
control "play" first. OK, we are clicking on play button. The variable 
"_playing" still has not changed on "true", so if code is:

...
        if (!_playing)
        {
            msg::wrn(_("Start playing...));
            c = command(command::toggle_play);
            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
        }
        else if (_pausing)
        {
            msg::wrn(_("Pause..."));
            c = command(command::toggle_pause);
        }
        else
        {
            msg::wrn(_("Do nothing..."));
            c = command(command::noop);
        }
...


We run "toggle-play" which stopped play bino without gui.
So if I can programm on C and C++ I will fix it, but I don't.

Robert

PS. I will add this bug to bug-tracks.

Robert_Pliszko.vcf
Description: Vcard