Re: Bitset patches

[Akim Demaille]

>>>>> "Paul" == Paul Eggert <address@hidden> writes:

>> From: Akim Demaille <address@hidden> Date: 28 Aug 2002 16:36:20
>> +0200
>> 
>> the following bits of your patch are related to Michael's
>> implementation of bitsets, which is also used in GCC.  So I guess
>> this should be applied to the main sources.

Paul> I didn't know they were also used in GCC.  I'm surprised about
Paul> this, since some of the fixes were prompted by GCC warnings on
Paul> 64-bit hosts.  But yes, those patches should be applied to the
Paul> upstream versions of the bitset code too.

Paul> Is GCC's version the canonical one, or does GCC get it from
Paul> somewhere else too?

Actually Michael's version was scheduled to replace the current one.
But I have still received no acknowledgement for the patches you
submitted.  Michael, do you have an updated version of bitset which
take into account the patches from Paul?  These:

2002-08-12  Paul Eggert  <address@hidden>

        * lib/abitset.c (abitset_reverse_list, ebitset_reverse_list):
        Do not assume that bitset_windex is the same width as unsigned.

        * lib/abitset.c (abitset_unused_clear): Do not assume that
        bitset_word is the same width as int.
        * lib/bbitset.h (BITSET_INDEX_MAX, BITSET_MSB): Likewise.
        * lib/bitset.h (bitset_set, bitset_reset): Likewise.
        * lib/bitset_stats.c (bitset_stats_set, bitset_stats_reset): Likewise.
        * lib/ebitset.c (ebitset_set, ebitset_reset): Likewise.
        * lib/lbitset.c (lbitset_set, lbitset_reset): Likewise.

        * lib/abitset.c (abitset_op1): Use -1, not ~0, as memset arg (for
        portability to one's complement hosts!).
        * lib/ebitset.c (ebitset_op1): Likewise.
        * lib/lbitset.c (lbitset_op1): Likewise.

        * lib/bbitset.h (BITSET_WORD_BITS): Now of type unsigned, not
        size_t; the old version tried to do this but casted improperly.
        (bitset_bindex, bitset_windex): Now size_t, not unsigned long.
        (bitset_test): Now returns int, not unsigned long.

        * lib/bitset_stats.c: Include "gettext.h".
        (_): New macro.
        (bitset_stats_set, bitset_stats_reset, bitset_stats_test): Don't
        name locals "index", as it generates unnecessary warnings on some
        hosts that have an "index" function.

        * lib/bitset_stats.c (bitset_stats_print_1, bitset_stats_print,
        bitset_stats_read, bitset_stats_write): Wrap strings in _() if
        they need translation.

I can resend the patch if you want.

Thanks in advance!