bison-patches
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: error-verbose yycheck overrun


From: Akim Demaille
Subject: Re: error-verbose yycheck overrun
Date: Tue, 04 Mar 2003 08:22:39 +0100
User-agent: Gnus/5.090015 (Oort Gnus v0.15) Emacs/21.2

| "Akim Demaille" <address@hidden> writes:
| > --- data/yacc.c     25 Feb 2003 07:57:48 -0000      1.53
| > +++ data/yacc.c     2 Mar 2003 13:16:34 -0000
| > ...
| > +     const char* yyprefix;
| >       char *yymsg;
| > ...
| > -           yycount++;
| > +           yycount += 1;
| 
| I would prefer to stick with the traditional C style where one uses
| "x++" rather than "x += 1", and "char *foo" rather than "char* foo".
| 
| glr.c uses a different style (due to Paul Hilfinger, I guess?) 

Yep.

| but it makes the code a bit harder for me to read, and I assume for
| others, and I'd rather not have that style be propagated to the rest
| of Bison, which is more traditional.

I'm fine with this, but I would nevertheless encourage ++i over i++ :(
Not for contradicting, but in order to augment as much as possible the
similarity between all the skeletons, and therefore use more C++
standards (where people pay more attention to the difference between
post- and pre-increment).




reply via email to

[Prev in Thread] Current Thread [Next in Thread]