[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: glr.c cleanup
From: |
Paul Hilfinger |
Subject: |
Re: glr.c cleanup |
Date: |
Thu, 08 Dec 2005 10:30:35 -0800 |
> >> (yyglrShift): Change parameter YYLTYPE* yylocp to YYLTYPE yyloc for
> >> consistency with parameter YYSTYPE yysval.
> >
> > I used yylocp here because the default location object is a multiword
> > thing, and I wanted to avoid passing its value.
>
> Minor issue, but what about YYSTYPE* yyvalp instead? This would be fairly
> consistent with other functions.
You could do that if you wanted. These are parameters that would be
const Foo& in C++, to avoid gratuitous invocation of a copy
constructor.
Paul Hilfinger
- Re: glr.c cleanup, (continued)
- Re: glr.c cleanup, Hans Aberg, 2005/12/07
- Re: glr.c cleanup, Joel E. Denny, 2005/12/07
- Re: glr.c cleanup, Hans Aberg, 2005/12/08
- Re: glr.c cleanup, Joel E. Denny, 2005/12/08
- Re: glr.c cleanup, Hans Aberg, 2005/12/08
- Re: glr.c cleanup, Hans Aberg, 2005/12/08
- Re: glr.c cleanup, Hans Aberg, 2005/12/08
Re: glr.c cleanup, Paul Hilfinger, 2005/12/07
Re: glr.c cleanup, Paul Hilfinger, 2005/12/07