Re: <reductions>

[Joel E. Denny]

On Wed, 10 Oct 2007, Wojciech Polak wrote:

> Anyway, I'm attaching current version
> against CVS head.  I adjusted also xml2xhtml.xsl and put your
> hack into bison.xsl (but named it ruleNumber instead of ruleKey
> - this way the second part shows the "use" attribute - what do
> you think?).

Either way is fine for me.  I see you put the key in bison.xsl.  If you do 
that, you should add the bison prefix.

> I would like to commit it, but the kernel attribute doesn't
> work as I expect. I wrote it this way:
> 
> src/print-xml.c (print_core):
> +      if (i < s->nitems) /* FIXME */
> +     kernel = true;
> 
> Help me to find a better way to determine if it's a kernel
> item set or not. If this is problematic, then I'll commit
> this patch without the kernel attribute.

I don't know why I proposed a kernel attribute.  The user can easily 
compute if an item is a kernel item: it's rule 0 or the dot is not at the 
beginning of the RHS.  Sorry for the distraction.

> P.S. Joel, you use "required" attribute inside <xsl:param>,
> but it's not part of XSLT, at least 1.0 AFAIK.

Thanks for catching that.  I've been writing a lot of 2.0 lately, and I 
got confused.

> Thus, Emacs nxml-mode (highly recommended mode, btw) shows me
> such XSLT as invalid. Maybe write it as XML comment?

A comment seems nice to me.