Re: Pushing candidates

[Akim Demaille]

Le 26 août 08 à 08:48, Joel E. Denny a écrit :
> > > address@hidden ~/src/urbi/2.0/bison $ git push -v fsf master:refs/
> > > heads/make-symbol
> > > Pushing to git://git.sv.gnu.org/bison
>
> That's the read-only URL.  You want:
>
>  ssh://git.sv.gnu.org/srv/git/bison

Ah!  Thanks a lot!

> > There is also one quite large change of lalr1.cc that I'm
> > not sure I will be able to split easily.  It is the result
> > of several incremental changes and some deep implementation
> > changes that have been squashed together.
> >
> > The titles of the changes:
>
> That's a long list.  After 2.4 is out, I hope it won't be too much  
> trouble
> to migrate these changes to master in small, easily reviewed patches  
> if
> they affect more than the C++ skeletons, especially the front-end.

There are very few changes in the front-end, mostly new tables
in output.c to make the handling of symbols easier.

The biggest change is the first move to variants.  Then there
several improvements that follow on top of it, much easier
to read.

> I have
> my own large patches that I wish to contribute one day, and I'd likely
> need to update them for your changes.

I'm eager to see them :)  ielr(1)?

> > > Add %precedence support.
>
> Is this for partial orders?

No, not yet.  But it's a means to give precedence to a token,
and no associativity.  So if there are associativity conflicts,
they remain and it fails at compile time.

> > > Support yyerrok in lalr1.cc.
>
> So, should I drop the similar patch I posted below?
>
>  http://lists.gnu.org/archive/html/bison-patches/2008-08/msg00014.html
>
> That would be fine by me.  Just let me know.

They are similar, I just kept an order closer to that in yacc.c.

address@hidden ~/src/urbi/2.0/bison $ git show  
f8e7e83 
                                                                                                                                                                              10 
:40:35
commit f8e7e83f835caea3a6ff296f65e7da0baee98659
Author: Akim Demaille <address@hidden>
Date:   Mon Aug 4 23:19:26 2008 +0200

    Support yyerrok in lalr1.cc.

    YYBACKUP is still to import back into lalr1.cc.

        * data/lalr1.cc (yyerrork, yyclearin, YYRECOVERING): Define.

diff --git a/data/lalr1.cc b/data/lalr1.cc
index 97cecfd..ad09a7b 100644
--- a/data/lalr1.cc
+++ b/data/lalr1.cc
@@ -675,9 +675,13 @@ b4_percent_code_get[]dnl

 #endif /* !YYDEBUG */

+#define yyerrok                (yyerrstatus_ = 0)
+#define yyclearin      (yychar = yyempty_)
+
 #define YYACCEPT       goto yyacceptlab
 #define YYABORT                goto yyabortlab
 #define YYERROR                goto yyerrorlab
+#define YYRECOVERING()  (!!yyerrstatus_)

 ]b4_namespace_open[
 #if YYERROR_VERBOSE
address@hidden ~/src/urbi/2.0/bison $

Another patch checks yyerrok in calc.at.



I have pushed my branch in candidates/make-symbol.

I would really like to see these changes integrated soon, so
maybe we should make a branch for the forth-coming 2.4 and
make master become the future 2.5?