|
From: | Akim Demaille |
Subject: | Re: [PATCH] yysyntax_error: make it manage its own memory. |
Date: | Wed, 16 Sep 2009 15:38:25 +0200 |
Le 11 sept. 2009 à 09:40, Joel E. Denny a écrit :
+# gcc warns about tautologies and fallacies involving comparisons for +# unsigned char. However, it doesn't produce these same warnings for+# size_t and many other types when the warnings would seem to make just+# as much sense. We ignore the warnings. +CFLAGS=`echo x"$CFLAGS" | sed s/-Werror// | sed s/^x//` +AT_COMPILE([[input]])
You might want to introduce something like this in tests/atconfig.in, or use "$O0CFLAGS $WARN_CFLAGS" instead of getting bits of $CFLAGS.
Other than that, the patches are fine, please install. (One note though, maybe we already debated about this, but I forgot: I prefer to use < and <= and not > and >=. Another lesson I took from Paul Eggert. Not everybody agrees.)
[Prev in Thread] | Current Thread | [Next in Thread] |