bison-patches
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: header file guards conflict


From: Stefano Lattarini
Subject: Re: header file guards conflict
Date: Mon, 21 May 2012 16:30:57 +0200

On 05/21/2012 04:00 PM, Akim Demaille wrote:
> 
> Le 21 mai 2012 à 15:33, Stefano Lattarini a écrit :
> 
>> Hi Akim.  I'm really not knowledgeable enough to comment on this
>> patch proper, but I have a nit about quotation usages ...
>>
>> On 05/21/2012 02:56 PM, Akim Demaille wrote:
>>>
>>> -** liby is no longer asking for "rpl_fprintf" on some platforms.
>>> +** liby is no longer asking for `rpl_fprintf' on some platforms.
>>>
>> ... here and in a similar change below: the GCS now recommend to quote
>> 'like this' or "like this", not `like this':
>>
>>  <http://www.gnu.org/prep/standards/html_node/Quote-Characters.html>
>>
>> and several packages have already begun to comply -- among them is Automake:
>>
>>  <http://lists.gnu.org/archive/html/bug-automake/2012-01/msg00056.html>
> 
> 
> Hi Stefano,
> 
> Yes, I am aware of this move, but actually, since currently
> the style is not converted in Bison, I wanted to first be
> consistent, as a kind of reminder.
>
Ah, OK.

> But you are right, it is actually simpler to convert right now.
>
> Note that bison, the program, is already converted,
>
Ah, in fact I seemed to remember some related Great Testsuite Churning
not much time ago :-)

> it's only NEWS.
>
Are you sure it is worth to convert also older NEWS entry to the new
quoting format?  For example, in Automake, we haven't done so.
Note however that I have no strong feelings on the issue, and I'm
not even suggesting that you should not convert the older entries;
just giving food for thought.

  I looked at coreutils, and its NEWS uses inconsistently
> '' or "" (well, at least I did not understand the pattern for
> one or the other).
> 
> Because ' is already used like this: "it's", "I'm" etc., I
> am tempted to promote "" over ''.
>
Personally, I'd use "" for sentences or quasi-sentences, and '' for
stuff like options, constants, variables, commit IDs, etc.  For
example, ...

>  ** C++11 compatibility:
>  
> -  C and C++ parsers use nullptr instead of 0 when __cplusplus is
> -  201103L or higher.
> +  C and C++ parsers use "nullptr" instead of "0" when __cplusplus is 201103L
> +  or higher.
> 
... here I'd use '' ...

> @@ -137,8 +133,8 @@ Bison News
>      %define lr.type canonical-lr
>  
>    The default-reduction optimization in the parser tables can also be
> -  adjusted using `%define lr.default-reductions'.  For details on both
> -  of these features, see the new section `Tuning LR' in the Bison
> +  adjusted using "%define lr.default-reductions".  For details on both
> +  of these features, see the new section "Tuning LR" in the Bison
>    manual.
>
... while here I'd use "" (as you've done).  Again, no strong feeling,
just a matter of personal taste.

Regards,
  Stefano



reply via email to

[Prev in Thread] Current Thread [Next in Thread]