Re: [bongo-devel] Re: Emacs 21

[Daniel Brockman]

address@hidden (Daniel Jensen) writes:

> Daniel Brockman <address@hidden> writes:
>
>> Romain Francoise <address@hidden> writes:
>>
>>> And now that it byte-compiles successfully in Emacs 21,
>>> it doesn't run:
>>>
>>> | Loading bongo...
>>> | Loading executable...done
>>> | byte-code: Invalid function: (macro . #[(obsolete-name
>>> | current-name &optional when docstring) "[bytecode snipped]"
>>> | [obsolete-name current-name when progn make-obsolete-variable] 5
>>> | ("/usr/share/emacs21/site-lisp/bongo/bongo-emacs21.elc" . 1838)])
>
> I'm guessing this is because the macro was not defined at compile
> time. It was later defined and compiled, but the previously compiled
> code does not know about that. Kind of hairy.

Indeed.  Thanks for explaining.

>> I don't see the fix immediately, and I actually just found
>> another byte-compilation problem (introduced by me recently).
>> I'll look into this as soon I find the time.
>
> I looked into it. I rearranged a few things for it to work.  Please try
> this patch.

Thank you.  Your patch fixed everything here so I
installed it.

> Note: `bongo-plist-get-all' is used at compile time. That is ...
> unorthodox, isn't it?

Actually, I didn't think using custom functions at compile
time was unorthodox.  I was quite surprised when it started
causing weird problems.

Maybe it is unorthodox.  I'll ask on gnu.emacs.help for
best practice and put this list on CC.

-- 
Daniel Brockman <address@hidden>