bongo-patches
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[bongo-patches] Fix bug preventing Bongo from understanding that VLC was


From: Daniel Brockman
Subject: [bongo-patches] Fix bug preventing Bongo from understanding that VLC was paused
Date: Thu, 08 Feb 2007 07:38:30 +0100
User-agent: Gnus/5.11 (Gnus v5.11) Emacs/23.0.51 (gnu/linux)

I don't really understand why this is suddenly necessary.
(Has anyone else had a problem with this?)

One might ask why they are using the numbers 1, 2, 3 and 4
instead of --- oh, I don't know... WORDS?

By the way, I started writing change log entries, but I
removed the ChangeLog file as soon as I realized how
annoying it would be to keep it in Darcs (conflicts ahoy!).

I decided to put the change log entries in Darcs patch
descriptions instead.  Here's how my mails will look now:


2007-02-08  Daniel Brockman  <address@hidden>

        Fix bug preventing Bongo from understanding that VLC was paused.

        (bongo-vlc-process-filter): Understand "play state: 3" to mean
        "playing", and "play state: 4" to mean "paused".


diff -rN -u old-bongo/bongo.el new-bongo/bongo.el
--- old-bongo/bongo.el  2007-02-08 07:32:14.000000000 +0100
+++ new-bongo/bongo.el  2007-02-08 07:32:14.000000000 +0100
@@ -4695,12 +4695,14 @@
                                      (zero-or-more (or space ")"))
                                      line-end))))
               (case (string-to-number (match-string 1))
-                (1 (bongo-player-put player 'paused nil)
-                   (bongo-player-paused/resumed player)
-                   (when (null (bongo-player-get player 'timer))
-                     (bongo-vlc-player-start-timer player)))
-                (2 (bongo-player-put player 'paused t)
-                   (bongo-player-paused/resumed player))))
+                ((1 3)
+                 (bongo-player-put player 'paused nil)
+                 (bongo-player-paused/resumed player)
+                 (when (null (bongo-player-get player 'timer))
+                   (bongo-vlc-player-start-timer player)))
+                ((2 4)
+                 (bongo-player-put player 'paused t)
+                 (bongo-player-paused/resumed player))))
              ((looking-at (eval-when-compile
                             (rx (and line-start
                                      (optional
-- 
Daniel Brockman <address@hidden>

reply via email to

[Prev in Thread] Current Thread [Next in Thread]