bug-auctex
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Bug-AUCTeX] 2014-07-13; Requests for the mark management improvemen


From: Ikumi Keita
Subject: Re: [Bug-AUCTeX] 2014-07-13; Requests for the mark management improvements
Date: Fri, 03 Oct 2014 13:56:29 +0900

Hi!

> But are you sure that changing the GNU Emacs version of
> `TeX-activate-region' from a no-op to the above has no undesired
> side-effects?  I mean, it's also used at some other places in latex.el,
> tex-info.el, and context.el.

I expect that the change doesn't bring about undesired side-effects.
Here is the summary of the investigation.

(1) The uses of `TeX-activate-region' in latex.el, tex-info.el and
    context.el are essentially the same.  It is used in
    `LaTeX-mark-environment', `LaTeX-mark-section' and its friends, and
    in the following form:

(defun XXX-mark-YYY (&optional ZZZ)
...
  (TeX-activate-region))

(2) There is one difference to `LaTeX-mark-environment' between before
    and after my change to `TeX-activate-region'.  When
    `transient-mark-mode' is nil, after `LaTeX-mark-environment'
    the region is...
    - not activated if `TeX-activate-region' is no-op
    - activated with `TeX-activate-region' with my change.

That is the only side-effect to `LaTeX-mark-environment' I'm aware of
currently.  I hope side-effects to others are limited to similar
harmless ones.

However, if you are afraid of undiscovered incompatibilities, I don't
adhere to changing `TeX-activate-region'.  In that case, I hope the
attached patch which just changes `push-mark' to `set-mark' in
`TeX-insert-dollar' would be helpful.

Regards,
Ikumi Keita

Attachment: only_push-mark_to_set-mark
Description: minimal change


reply via email to

[Prev in Thread] Current Thread [Next in Thread]