Re: [PATCH] bug in list of files displayed on 'automake --help'

[Tom Tromey]

>>>>> "Gary" == Gary V Vaughan <address@hidden> writes:

Gary> That seems like a terribly complicated way to achieve it.  My
Gary> patch on branch-1-4 seems cleaner...

I don't think we want patches in 1.4 that aren't also evaluated for
1.5.

Did you send this patch to automake-patches?  You might not be aware
of that requirement?  (Sometimes I'm not :-)

If I understand correctly, your patch adds the `+ 1' here:

        $two = $lcomm[$max + $i + 1];
        $three = $lcomm[2 * $max + $i + 1];
        $four = $lcomm[3 * $max + $i + 1];

I think this happens to work because the modulus is 1 right now.  Does
it work even if you add or remove an element from @common_files?

If the modulus were 2 then I think you'd have to remove the `+ 1' from
the $two line.

Do you agree?

Tom