bug-automake
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Bad handling of libtoolize


From: Matthew Gregg Knepley
Subject: Bad handling of libtoolize
Date: Mon, 26 Nov 2001 13:23:11 -0500

spinetta> automake --version
automake (GNU automake) 1.4

Copyright (C) 1999 Free Software Foundation, Inc.
This is free software; see the source for copying conditions.  There is NO
warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.

Written by Tom Tromey <address@hidden>

        When libtoolize needs to add missing files, the logic is not really
right. Here is my suggestion:

6886,6896c6886,6891
<                       && grep ($_ eq $file, @libtoolize_files))
<                     {
<                         local @args = ('libtoolize', '--automake', '--force');
< 
<                         $message = "installing \`$errfile'";
<                       if ($copy_missing) {push @args, ('--copy');}
<                         if (system (@args))
<                       {
<                           $suppress = 0;
<                           $trailer = "; cannot run \`libtoolize': $!";
<                         }
---
>                       && grep ($_ eq $file, @libtoolize_files)
>                       && system ('libtoolize', '--automake'))
>                   {
>                       $message = "installing \`$errfile'";
>                       $suppress = 0;
>                       $trailer = "; cannot run \`libtoolize': $!";

Basically, I wanted the --copy argument, and the message should be reset
earlier. I am sorry about the spacing, but I really hate tabs.

        Thanks,

                Matt



reply via email to

[Prev in Thread] Current Thread [Next in Thread]