bug-automake
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

patch to automake 1.6.3 : bug in aclocal.m4 dependencies when builddir


From: Karl Chen
Subject: patch to automake 1.6.3 : bug in aclocal.m4 dependencies when builddir != srcdir
Date: Wed, 07 Aug 2002 18:18:51 -0700

Hi, I believe there is a bug in generating the aclocal.m4 dependencies when in a build directory.

automake 1.6.3 generates aclocal.m4 dependencies that look like this:

$(ACLOCAL_M4):  configure.in m4macros/compilers.m4 m4macros/debug.m4 m4macros/helios.m4 m4macros/libtool.m4 m4macros/optimization.m4 m4macros/python.m4 m4macros/warning.m4
        cd $(srcdir) && $(ACLOCAL) $(ACLOCAL_AMFLAGS)

but I believe they should look like this:

$(ACLOCAL_M4):  configure.in $(top_srcdir)/m4macros/btng.m4 $(top_srcdir)/m4macros/compilers.m4 $(top_srcdir)/m4macros/debug.m4 $(top_srcdir)/m4macros/helios.m4 $(top_srcdir)/m4macros/optimization.m4 $(top_srcdir)/m4macros/python.m4 $(top_srcdir)/m4macros/warning.m4
        cd $(srcdir) && $(ACLOCAL) $(ACLOCAL_AMFLAGS)

I guess a dependency needs the "$(top_srcdir)/" only if it includes a path (thus configure.in doesn't need it, although I don't know if it's possible to have configure.in not be in the top_srcdir)


Here is a patch to fix it:

[06:09pm] address@hidden automake-1.6.3-mod $ diff -u automake.in ../automake-1.6.3/automake.in
--- automake.in 2002-08-07 17:53:07.000000000 -0700
+++ ../automake-1.6.3/automake.in       2002-07-25 14:13:17.000000000 -0700
@@ -3825,7 +3825,7 @@
                    foreach my $ac_dep (&my_glob ($amdir . '/*.m4'))
                    {
                        $ac_dep =~ s/^\.\/+//;
-                       push (@ac_deps, '$(top_srcdir)/' . $ac_dep)
+                       push (@ac_deps, $ac_dep)
                          unless $ac_dep eq "aclocal.m4"
                            || $ac_dep eq "acinclude.m4";
                    }

Thanks.

--
Karl Chen / address@hidden / (925)-422-7509


reply via email to

[Prev in Thread] Current Thread [Next in Thread]