[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Bug-gnulib] Re: fnmatch.c includes alloca.h conditionally?
From: |
Paul Eggert |
Subject: |
Re: [Bug-gnulib] Re: fnmatch.c includes alloca.h conditionally? |
Date: |
Tue, 20 Apr 2004 15:40:17 -0700 |
User-agent: |
Gnus/5.1006 (Gnus v5.10.6) Emacs/21.3 (gnu/linux) |
Derek Robert Price <address@hidden> writes:
> Actually, fnmatch.c still calls alloca() unconditionally, but it does
> look to me like the dependency reference in modules/argp can be removed.
> ...
>>Wouldn't it be simpler to change gl_FUNC_ALLOCA to always define
> HAVE_ALLOCA_H?
>
> This would work if you removed the #include <alloca.h> from
> alloca_.h. In this case, I should think alloca_.h should #define
> HAVE_ALLOCA on platforms where it is deemed faster than malloc, such
> as when #ifdef _MSC_VER, as well.
Yes, that makes sense.
How about this idea: wait a day or two for Bruno to comment, and if he
doesn't then write up a patch?