[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: dist-hook and rights

From: Alexandre Duret-Lutz
Subject: Re: dist-hook and rights
Date: Sat, 01 May 2004 15:24:49 +0200
User-agent: Gnus/5.1003 (Gnus v5.10.3) Emacs/21.3.50 (gnu/linux)

>>> "Akim" == Akim Demaille <address@hidden> writes:


 >> I do not understand this.  dist-hook is there to allow modifications
 >> of things inside $(distdir)/.  I believe this directory is never
 >> read-only.

 Akim> Actually, it may be, and especially during the inner dist!  But you
 Akim> know this, as shows your next paragraph.

Hmm.  That next paragraph was about the inneer $(srcdir), not
the innder $(distdir).


 Akim> The perms are fixed after dist-hook, so the inner distdir
 Akim> builds an inner builddir with basically `cp', hence it
 Akim> propagates the read-only permissions from the source
 Akim> tree.

Ah, yes, I forgot about that.  It has also been a source of
problem in the past.  See for instance PR/390 where a directory
that contains automatically distributed files is EXTRA_DISTed:
during `make distdir', the automatically distributed files are
first copied, and then the recursive copy of the directory fails
because it cannot overwrite the files that have already been

 Akim> It is only after that dist-hook was running that the
 Akim> write permissions are restored in builddir.


 Akim> let's add another chmod-restoring find invocation before
 Akim> running dist-hook.

That sounds fine to me, although it doesn't fix PR/390.  Maybe
we should rather find a way to copy files with the right
Alexandre Duret-Lutz

reply via email to

[Prev in Thread] Current Thread [Next in Thread]