bug-automake
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

To inner_expand or not to inner_expand; that is... (was: More on problem


From: Ray Simard
Subject: To inner_expand or not to inner_expand; that is... (was: More on problem with makefile variable expansion)
Date: Thu, 01 Jul 2004 14:18:26 -0700
User-agent: Mozilla Thunderbird 0.5+ (X11/20040212)

OK, found the code block to handle inner expansions if the
inner_expand option is set. Looking through automake and
Variable.pm, it seems that inner_expand is never set. That
is what was causing the problems.

If I read the Variable.pm man page correctly, inner_expand is
supposed to be on by default. Is that accurate? If so, is
there any reason why the following patch would not be
appropriate?

Thanks for any help.
Ray Simard

==========================================================
diff -uNr Variable.pm Variable.pm
--- Variable.pm 2004-06-30 22:39:20.000000000 -0700
+++ Variable.pm 2004-07-01 14:09:05.000000000 -0700
@@ -1255,6 +1255,7 @@
  my ($var, $fun_item, $fun_collect, %options) = @_;
  my $cond_filter = $options{'cond_filter'};
  my $inner_expand = $options{'inner_expand'};
+  $inner_expand = 1 unless defined $inner_expand;
  return $var->_do_recursive_traversal ($var,
                                       $fun_item, $fun_collect,
                                       $cond_filter, TRUE, $inner_expand)
==========================================================





reply via email to

[Prev in Thread] Current Thread [Next in Thread]