bug-automake
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: automake 1.8d: missing regexp quoting


From: Alexandre Duret-Lutz
Subject: Re: automake 1.8d: missing regexp quoting
Date: Wed, 21 Jul 2004 19:49:40 +0200
User-agent: Gnus/5.1003 (Gnus v5.10.3) Emacs/21.3.50 (gnu/linux)

>>> "Andreas" == Andreas Schwab <address@hidden> writes:

[...]

 >>> -    if grep (/^$dir$/i, qw/aux lpt1 lpt2 lpt3 com1 com2 com3 com4 con 
 >>> prn/);
 >>> +    if grep (/^\Q$dir\E$/i, qw/aux lpt1 lpt2 lpt3 com1 com2 com3 com4 con 
 >>> prn/);
 >> 
 >> I'm afraid I have no idea what this fixes.  Can you explain?

 Andreas> $dir can contain any kind of special regexp characters, even
 Andreas> syntactically invalid.

Sorry, I've now got my brains turned on; when I first read the
grep statement I though $dir was ranging over aux...prn and
quoting would not matters.

I guess a "Automake complains on `SUBDIRS = a.x'" note would
have been more appropriate to wake me up.
-- 
Alexandre Duret-Lutz





reply via email to

[Prev in Thread] Current Thread [Next in Thread]